[V8] Use Function.name in Error.stack

src/isolate.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdlib.h>
 
 #include <fstream>  // NOLINT(readability/streams)
 #include <sstream>
 
 #include "src/v8.h"
@@ skipping 465 matching lines @@
       script_name_key_ =
           factory()->InternalizeOneByteString(STATIC_CHAR_VECTOR("scriptName"));
     }
     if (options & StackTrace::kScriptNameOrSourceURL) {
       script_name_or_source_url_key_ = factory()->InternalizeOneByteString(
           STATIC_CHAR_VECTOR("scriptNameOrSourceURL"));
     }
     if (options & StackTrace::kFunctionName) {
       function_key_ = factory()->InternalizeOneByteString(
           STATIC_CHAR_VECTOR("functionName"));
-      name_key_ =
-          factory()->InternalizeOneByteString(STATIC_CHAR_VECTOR("name"));
     }
     if (options & StackTrace::kIsEval) {
       eval_key_ =
           factory()->InternalizeOneByteString(STATIC_CHAR_VECTOR("isEval"));
     }
     if (options & StackTrace::kIsConstructor) {
       constructor_key_ = factory()->InternalizeOneByteString(
           STATIC_CHAR_VECTOR("isConstructor"));
     }
   }
@@ skipping 41 matching lines @@
                             handle(script->name(), isolate_), NONE);
     }
 
     if (!script_name_or_source_url_key_.is_null()) {
       Handle<Object> result = Script::GetNameOrSourceURL(script);
       JSObject::AddProperty(stack_frame, script_name_or_source_url_key_, result,
                             NONE);
     }
 
     if (!function_key_.is_null()) {
-      Handle<Object> fun_name = JSObject::GetDataProperty(fun, name_key_);
-      if (!fun_name->IsString())
-        fun_name = Handle<Object>(fun->shared()->DebugName(), isolate_);
+      Handle<Object> fun_name = JSFunction::GetDebugName(fun);
       JSObject::AddProperty(stack_frame, function_key_, fun_name, NONE);
     }
 
     if (!eval_key_.is_null()) {
       Handle<Object> is_eval = factory()->ToBoolean(
           script->compilation_type() == Script::COMPILATION_TYPE_EVAL);
       JSObject::AddProperty(stack_frame, eval_key_, is_eval, NONE);
     }
 
     if (!constructor_key_.is_null()) {
@@ skipping 10 matching lines @@
 
   Isolate* isolate_;
   Handle<String> column_key_;
   Handle<String> line_key_;
   Handle<String> script_id_key_;
   Handle<String> script_name_key_;
   Handle<String> script_name_or_source_url_key_;
   Handle<String> function_key_;
   Handle<String> eval_key_;
   Handle<String> constructor_key_;
-  Handle<String> name_key_;
 };
 
 
 Handle<JSArray> Isolate::GetDetailedFromSimpleStackTrace(
     Handle<JSObject> error_object) {
   Handle<Name> key = factory()->stack_trace_symbol();
   Handle<Object> property = JSObject::GetDataProperty(error_object, key);
   if (!property->IsJSArray()) return Handle<JSArray>();
   Handle<JSArray> simple_stack_trace = Handle<JSArray>::cast(property);
 
@@ skipping 2027 matching lines @@
   if (prev_ && prev_->Intercept(flag)) return true;
   // Then check whether this scope intercepts.
   if ((flag & intercept_mask_)) {
     intercepted_flags_ |= flag;
     return true;
   }
   return false;
 }
 
 } }  // namespace v8::internal