[V8] Use Function.name in Error.stack

src/objects.cc

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <iomanip>
 #include <sstream>
 
 #include "src/v8.h"
 
 #include "src/accessors.h"
@@ skipping 10309 matching lines @@
     return true;
   }
   if (filter[filter.length() - 1] == '*' &&
       name->IsUtf8EqualTo(filter.SubVector(0, filter.length() - 1), true)) {
     return true;
   }
   return false;
 }
 
 
+String* JSFunction::DebugName() {

[Yang, 2015/03/13 13:19:13]

This is not GC-safe. GetDataProperty may cause GC, at which point the JSFunction
itself (this) may be moved and becomes invalid. Calling shared() would then
crash.

Please turn all of this into handlified code with this signature:

(static) Handle<String> JSFunction::DebugName(Handle<JSFunction>).

[kozy, 2015/03/13 14:05:14]

Done.

+  Handle<JSFunction> self(this);
+  Handle<Object> name =
+      JSObject::GetDataProperty(self, GetIsolate()->factory()->name_string());
+  if (name->IsString()) return String::cast(*name);
+  return shared()->DebugName();
+}
+
+
 void Oddball::Initialize(Isolate* isolate,
                          Handle<Oddball> oddball,
                          const char* to_string,
                          Handle<Object> to_number,
                          byte kind) {
   Handle<String> internalized_to_string =
       isolate->factory()->InternalizeUtf8String(to_string);
   oddball->set_to_string(*internalized_to_string);
   oddball->set_to_number(*to_number);
   oddball->set_kind(kind);
@@ skipping 6789 matching lines @@
                                                CompilationInfo* info) {
   Handle<DependentCode> codes = DependentCode::InsertCompilationInfo(
       handle(cell->dependent_code(), info->isolate()),
       DependentCode::kPropertyCellChangedGroup, info->object_wrapper());
   if (*codes != cell->dependent_code()) cell->set_dependent_code(*codes);
   info->dependencies(DependentCode::kPropertyCellChangedGroup)->Add(
       cell, info->zone());
 }
 
 } }  // namespace v8::internal