Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 919643008: Remove --experimental-classes flag and related dead code. (Closed)

Created:
5 years, 10 months ago by Dmitry Lomov (no reviews)
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove --experimental-classes flag and related dead code. R=arv@chromium.org BUG=v8:3834 LOG=N Committed: https://crrev.com/7866f00508a2a3b0f18442787eee67ee4a094d72 Cr-Commit-Position: refs/heads/master@{#26631}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -522 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 2 chunks +2 lines, -11 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 2 chunks +2 lines, -11 lines 0 comments Download
M src/ast.cc View 1 chunk +1 line, -1 line 0 comments Download
D src/ast-this-access-visitor.h View 1 chunk +0 lines, -34 lines 0 comments Download
D src/ast-this-access-visitor.cc View 1 chunk +0 lines, -239 lines 0 comments Download
M src/compiler.cc View 2 chunks +0 lines, -71 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 2 chunks +2 lines, -11 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 2 chunks +2 lines, -11 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 2 chunks +2 lines, -11 lines 0 comments Download
M src/objects.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/parser.cc View 5 chunks +9 lines, -21 lines 0 comments Download
M src/ppc/full-codegen-ppc.cc View 1 chunk +1 line, -9 lines 0 comments Download
M src/preparser.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-classes.cc View 2 chunks +3 lines, -54 lines 0 comments Download
M src/scopes.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/x64/full-codegen-x64.cc View 2 chunks +2 lines, -11 lines 0 comments Download
M src/x87/full-codegen-x87.cc View 2 chunks +2 lines, -11 lines 0 comments Download
M test/mjsunit/harmony/classes-experimental.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/regress/regress-455141.js View 1 chunk +1 line, -1 line 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Dmitry Lomov (no reviews)
PTAL
5 years, 10 months ago (2015-02-12 19:02:14 UTC) #1
Dmitry Lomov (no reviews)
cq is drunk...
5 years, 10 months ago (2015-02-12 19:21:45 UTC) #2
arv (Not doing code reviews)
LGTM
5 years, 10 months ago (2015-02-12 19:50:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/919643008/1
5 years, 10 months ago (2015-02-12 20:02:13 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7866f00508a2a3b0f18442787eee67ee4a094d72 Cr-Commit-Position: refs/heads/master@{#26631}
5 years, 10 months ago (2015-02-12 20:07:23 UTC) #7
Dmitry Lomov (no reviews)
5 years, 10 months ago (2015-02-12 20:07:25 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
7866f00508a2a3b0f18442787eee67ee4a094d72 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698