Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1364)

Unified Diff: src/serialize.cc

Issue 919613002: Whitelist serialized objects wrt MSAN. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/serialize.cc
diff --git a/src/serialize.cc b/src/serialize.cc
index 887276f9cf0dc1b65e6f90432e14cea0b205e9e3..ae3b3a2b2e24d9b64c7b06bafe779f1e84c74760 100644
--- a/src/serialize.cc
+++ b/src/serialize.cc
@@ -2120,6 +2120,10 @@ int Serializer::ObjectSerializer::OutputRawData(
}
const char* description = code_object_ ? "Code" : "Byte";
+#ifdef MEMORY_SANITIZER
+ // Object sizes are usually rounded up with uninitialized padding space.
+ MSAN_MEMORY_IS_INITIALIZED(object_start + base, bytes_to_output);
+#endif // MEMORY_SANITIZER
sink_->PutRaw(object_start + base, bytes_to_output, description);
if (code_object_) delete[] object_start;
}
@@ -2529,6 +2533,7 @@ class Checksum {
#endif // V8_HOST_ARCH_64_BIT
a_ = static_cast<uint32_t>(a);
b_ = static_cast<uint32_t>(b);
+ printf("%d, %d\n", a_, b_);
jochen (gone - plz use gerrit) 2015/02/11 13:08:45 Why is that needed?
Yang 2015/02/11 13:24:15 Ummm.. hehe.. it's not.
}
bool Check(uint32_t a, uint32_t b) const { return a == a_ && b == b_; }
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698