Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 919613002: Whitelist serialized objects wrt MSAN. (Closed)

Created:
5 years, 10 months ago by Yang
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Whitelist serialized objects wrt MSAN. R=jochen@chromium.org BUG=chromium:457459 LOG=N Committed: https://crrev.com/5d1a9b09f32181f978a834b286914ce466be688e Cr-Commit-Position: refs/heads/master@{#26578}

Patch Set 1 #

Total comments: 2

Patch Set 2 : removed printf #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/serialize.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Yang
5 years, 10 months ago (2015-02-11 12:32:35 UTC) #1
jochen (gone - plz use gerrit)
https://codereview.chromium.org/919613002/diff/1/src/serialize.cc File src/serialize.cc (right): https://codereview.chromium.org/919613002/diff/1/src/serialize.cc#newcode2536 src/serialize.cc:2536: printf("%d, %d\n", a_, b_); Why is that needed?
5 years, 10 months ago (2015-02-11 13:08:45 UTC) #2
Yang
Thanks for catching this. https://codereview.chromium.org/919613002/diff/1/src/serialize.cc File src/serialize.cc (right): https://codereview.chromium.org/919613002/diff/1/src/serialize.cc#newcode2536 src/serialize.cc:2536: printf("%d, %d\n", a_, b_); On ...
5 years, 10 months ago (2015-02-11 13:24:15 UTC) #3
jochen (gone - plz use gerrit)
lgtm
5 years, 10 months ago (2015-02-11 14:00:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/919613002/20001
5 years, 10 months ago (2015-02-11 14:01:45 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-11 14:03:15 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-11 14:03:32 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5d1a9b09f32181f978a834b286914ce466be688e
Cr-Commit-Position: refs/heads/master@{#26578}

Powered by Google App Engine
This is Rietveld 408576698