Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 919473008: Use just one to-space page for the promotion queue. (Closed)

Created:
5 years, 10 months ago by Hannes Payer (out of office)
Modified:
5 years, 10 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use just one to-space page for the promotion queue. BUG=454725 LOG=n Committed: https://crrev.com/c889fb4c1dac8f0d8fcab16ffc93288a1d7ea2b7 Cr-Commit-Position: refs/heads/master@{#26577}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -17 lines) Patch
M src/heap/heap.h View 1 4 chunks +13 lines, -6 lines 0 comments Download
M src/heap/heap.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M src/heap/heap-inl.h View 1 chunk +0 lines, -7 lines 0 comments Download
A test/mjsunit/regress/regress-454725.js View 1 2 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Jarin
lgtm. I just hope we do not use the promotion queue as a funky way ...
5 years, 10 months ago (2015-02-11 12:46:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/919473008/40001
5 years, 10 months ago (2015-02-11 13:17:15 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-11 13:39:37 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-11 13:39:52 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c889fb4c1dac8f0d8fcab16ffc93288a1d7ea2b7
Cr-Commit-Position: refs/heads/master@{#26577}

Powered by Google App Engine
This is Rietveld 408576698