Issue 919463004: Build sky/engine/tonic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 919463004: Build sky/engine/tonic (Closed)

Created:
5 years, 10 months ago by abarth-chromium

Modified:
5 years, 10 months ago

Reviewers:
rafaelw

CC:
esprehn, mojo-reviews_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Build sky/engine/tonic This CL adds a dependency from Sky to DartVM. We need to remove Sky from the ASAN build because DartVM doesn't currently build in ASAN (see https://code.google.com/p/dart/issues/detail?id=22121). R=rafaelw@chromium.org BUG=454613 Committed: https://chromium.googlesource.com/external/mojo/+/cc25898f60cf603f4eaa0f98ad1c483b6eb7af25

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	BUILD.gn	View		2 chunks	+4 lines, -1 line	0 comments	Download
	M	sky/engine/core/BUILD.gn	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

abarth-chromium

5 years, 10 months ago (2015-02-12 21:18:28 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
cc25898f60cf603f4eaa0f98ad1c483b6eb7af25 (presubmit successful).