Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(882)

Unified Diff: public/web/WebViewClient.h

Issue 919423002: Audited and renamed uses of methods and variables named RootView (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase again Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « public/web/WebView.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/web/WebViewClient.h
diff --git a/public/web/WebViewClient.h b/public/web/WebViewClient.h
index 5427c31d9278ac04254d13fc2d97e743c520dc81..f73cb9708f473a27f29502620cbec0ce33a83ed1 100644
--- a/public/web/WebViewClient.h
+++ b/public/web/WebViewClient.h
@@ -153,13 +153,15 @@ public:
// Show a notification popup for the specified form vaidation messages
// besides the anchor rectangle. An implementation of this function should
// not hide the popup until hideValidationMessage call.
- virtual void showValidationMessage(const WebRect& anchorInRootView, const WebString& mainText, WebTextDirection mainTextDir, const WebString& supplementalText, WebTextDirection supplementalTextDir) { }
+ // FIXME: Clarify anchor coordinates in variable name on Chromium-side.
+ virtual void showValidationMessage(const WebRect& anchorInViewport, const WebString& mainText, WebTextDirection mainTextDir, const WebString& supplementalText, WebTextDirection supplementalTextDir) { }
// Hide notifation popup for form validation messages.
virtual void hideValidationMessage() { }
// Move the existing notifation popup to the new anchor position.
- virtual void moveValidationMessage(const WebRect& anchorInRootView) { }
+ // FIXME: Clarify anchor coordinates in variable name on Chromium-side.
+ virtual void moveValidationMessage(const WebRect& anchorInViewport) { }
// UI ------------------------------------------------------------------
« no previous file with comments | « public/web/WebView.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698