Source/web/PopupMenuTest.cpp - Issue 919423002: Audited and renamed uses of methods and variables named RootView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/PopupMenuTest.cpp

Issue 919423002: Audited and renamed uses of methods and variables named RootView (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase again Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/PopupMenuTest.cpp

diff --git a/Source/web/PopupMenuTest.cpp b/Source/web/PopupMenuTest.cpp

index 7b39178611e114d09a7d1b5d23573b299da4d943..3255af53bd50581cab545c5cadc2d3cb87fa8f97 100644

--- a/Source/web/PopupMenuTest.cpp

+++ b/Source/web/PopupMenuTest.cpp

@@ -125,7 +125,7 @@ public:

virtual bool itemIsSelected(unsigned listIndex) const { return listIndex == m_selectIndex; }

virtual bool valueShouldChangeOnHotTrack() const { return false; }

virtual void setTextFromItem(unsigned listIndex) { }

- virtual IntRect elementRectRelativeToRootView() const override { return IntRect(); }

+ virtual IntRect elementRectRelativeToViewport() const override { return IntRect(); }

virtual Element& ownerElement() const override { return *toElement(m_node); }

virtual LayoutStyle* layoutStyleForItem(Element& element) const override { return nullptr; }

« no previous file with comments | « Source/web/PopupMenuImpl.cpp ('k') | Source/web/ValidationMessageClientImpl.cpp » ('j') | no next file with comments »