Source/web/PopupContainer.cpp - Issue 919423002: Audited and renamed uses of methods and variables named RootView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/PopupContainer.cpp

Issue 919423002: Audited and renamed uses of methods and variables named RootView (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase again Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/PopupContainer.cpp

diff --git a/Source/web/PopupContainer.cpp b/Source/web/PopupContainer.cpp

index 251c77b9f31ad0d0a67d3db33d71e079b5923cdb..d1d49f5b089d8e1bdb7275b70487697e34538393 100644

--- a/Source/web/PopupContainer.cpp

+++ b/Source/web/PopupContainer.cpp

@@ -206,7 +206,7 @@ IntRect PopupContainer::layoutAndCalculateWidgetRect(int targetControlHeight, co

float pageScaleFactor = m_frameView->frame().page()->pageScaleFactor();

int popupX = round((popupInitialCoordinate.x() + rightOffset) * pageScaleFactor);

int popupY = round((popupInitialCoordinate.y() + verticalForRTLOffset) * pageScaleFactor);

- widgetRectInScreen = chromeClient().rootViewToScreen(IntRect(popupX, popupY, targetSize.width(), targetSize.height()));

+ widgetRectInScreen = chromeClient().viewportToScreen(IntRect(popupX, popupY, targetSize.width(), targetSize.height()));

// If we have multiple screens and the browser rect is in one screen, we

// have to clip the window width to the screen width.

« no previous file with comments | « Source/web/ExternalPopupMenuTest.cpp ('k') | Source/web/PopupMenuImpl.cpp » ('j') | no next file with comments »