Source/web/DateTimeChooserImpl.cpp - Issue 919423002: Audited and renamed uses of methods and variables named RootView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/DateTimeChooserImpl.cpp

Issue 919423002: Audited and renamed uses of methods and variables named RootView (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase again Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/DateTimeChooserImpl.cpp

diff --git a/Source/web/DateTimeChooserImpl.cpp b/Source/web/DateTimeChooserImpl.cpp

index 9d0ce13a2197613ed1c7d1dd0c636afc39b77448..670f97a698355787208dfe17b9f0e154907c691f 100644

--- a/Source/web/DateTimeChooserImpl.cpp

+++ b/Source/web/DateTimeChooserImpl.cpp

@@ -55,7 +55,7 @@ DateTimeChooserImpl::DateTimeChooserImpl(ChromeClientImpl* chromeClient, DateTim

{

ASSERT(m_chromeClient);

ASSERT(m_client);

- m_popup = m_chromeClient->openPagePopup(this, m_parameters.anchorRectInRootView);

+ m_popup = m_chromeClient->openPagePopup(this);

}

PassRefPtr<DateTimeChooserImpl> DateTimeChooserImpl::create(ChromeClientImpl* chromeClient, DateTimeChooserClient* client, const DateTimeChooserParameters& parameters)

@@ -106,7 +106,6 @@ void DateTimeChooserImpl::writeDocument(SharedBuffer* data)

{

String stepString = String::number(m_parameters.step);

String stepBaseString = String::number(m_parameters.stepBase, 11, WTF::TruncateTrailingZeros);

- IntRect anchorRectInScreen = m_chromeClient->rootViewToScreen(m_parameters.anchorRectInRootView);

String todayLabelString;

String otherDateLabelString;

if (m_parameters.type == InputTypeNames::month) {

@@ -127,7 +126,7 @@ void DateTimeChooserImpl::writeDocument(SharedBuffer* data)

data->append(Platform::current()->loadResource("calendarPicker.css"));

addString("</style></head><body><div id=main>Loading...</div><script>\n"

"window.dialogArguments = {\n", data);

- addProperty("anchorRectInScreen", anchorRectInScreen, data);

+ addProperty("anchorRectInScreen", m_parameters.anchorRectInScreen, data);

addProperty("min", valueToDateTimeString(m_parameters.minimum, m_parameters.type), data);

addProperty("max", valueToDateTimeString(m_parameters.maximum, m_parameters.type), data);

addProperty("step", stepString, data);

@@ -159,7 +158,7 @@ void DateTimeChooserImpl::writeDocument(SharedBuffer* data)

addProperty("suggestionValues", suggestionValues, data);

addProperty("localizedSuggestionValues", localizedSuggestionValues, data);

addProperty("suggestionLabels", suggestionLabels, data);

- addProperty("inputWidth", static_cast<unsigned>(m_parameters.anchorRectInRootView.width()), data);

+ addProperty("inputWidth", static_cast<unsigned>(m_parameters.anchorRectInRootFrame.width()), data);

addProperty("showOtherDateEntry", LayoutTheme::theme().supportsCalendarPicker(m_parameters.type), data);

addProperty("otherDateLabel", otherDateLabelString, data);

addProperty("suggestionHighlightColor", LayoutTheme::theme().activeListBoxSelectionBackgroundColor().serialized(), data);

« no previous file with comments | « Source/web/ColorChooserPopupUIController.cpp ('k') | Source/web/ExternalDateTimeChooser.cpp » ('j') | no next file with comments »