Source/web/ChromeClientImpl.h - Issue 919423002: Audited and renamed uses of methods and variables named RootView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/ChromeClientImpl.h

Issue 919423002: Audited and renamed uses of methods and variables named RootView (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase again Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/ChromeClientImpl.h

diff --git a/Source/web/ChromeClientImpl.h b/Source/web/ChromeClientImpl.h

index c57ad0808e155a5dcda9018091895191d5be2003..ee343e443743dcbcc95f6bd5e0b384ca219c1415 100644

--- a/Source/web/ChromeClientImpl.h

+++ b/Source/web/ChromeClientImpl.h

@@ -112,7 +112,7 @@ public:

virtual void invalidateRect(const IntRect&) override;

virtual void scheduleAnimation() override;

virtual void scheduleAnimationForFrame(LocalFrame* localRoot) override;

- virtual IntRect rootViewToScreen(const IntRect&) const override;

+ virtual IntRect viewportToScreen(const IntRect&) const override;

virtual WebScreenInfo screenInfo() const override;

virtual void contentsSizeChanged(LocalFrame*, const IntSize&) const override;

virtual void pageScaleFactorChanged() const override;

@@ -153,7 +153,7 @@ public:

virtual bool hasOpenedPopup() const override;

virtual PassRefPtrWillBeRawPtr<PopupMenu> createPopupMenu(LocalFrame&, PopupMenuClient*) override;

- PagePopup* openPagePopup(PagePopupClient*, const IntRect&);

+ PagePopup* openPagePopup(PagePopupClient*);

void closePagePopup(PagePopup*);

virtual DOMWindow* pagePopupWindowForTesting() const override;

« no previous file with comments | « Source/platform/HostWindow.h ('k') | Source/web/ChromeClientImpl.cpp » ('j') | no next file with comments »