Source/core/page/DragController.cpp - Issue 919423002: Audited and renamed uses of methods and variables named RootView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/DragController.cpp

Issue 919423002: Audited and renamed uses of methods and variables named RootView (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase again Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/page/DragController.cpp

diff --git a/Source/core/page/DragController.cpp b/Source/core/page/DragController.cpp

index bb2cd14a51563b8d4aa8a1dc1cc448fdae17df61..11995add98ceec36cefc36268394623db6feb5b2 100644

--- a/Source/core/page/DragController.cpp

+++ b/Source/core/page/DragController.cpp

@@ -934,8 +934,8 @@ void DragController::doSystemDrag(DragImage* image, const IntPoint& dragLocation

RefPtrWillBeRawPtr<LocalFrame> mainFrame = m_page->deprecatedLocalMainFrame();

RefPtrWillBeRawPtr<FrameView> mainFrameView = mainFrame->view();

- m_client->startDrag(image, mainFrameView->rootViewToContents(frame->view()->contentsToRootView(dragLocation)),

- mainFrameView->rootViewToContents(frame->view()->contentsToRootView(eventPos)), dataTransfer, frame, forLink);

+ m_client->startDrag(image, mainFrameView->rootFrameToContents(frame->view()->contentsToRootFrame(dragLocation)),

+ mainFrameView->rootFrameToContents(frame->view()->contentsToRootFrame(eventPos)), dataTransfer, frame, forLink);

// DragClient::startDrag can cause our Page to dispear, deallocating |this|.

if (!frame->page())

return;

« no previous file with comments | « Source/core/page/ChromeClient.h ('k') | Source/core/page/EventHandler.cpp » ('j') | no next file with comments »