Source/core/html/forms/PopupMenuClient.h - Issue 919423002: Audited and renamed uses of methods and variables named RootView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/forms/PopupMenuClient.h

Issue 919423002: Audited and renamed uses of methods and variables named RootView (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase again Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/forms/PopupMenuClient.h

diff --git a/Source/core/html/forms/PopupMenuClient.h b/Source/core/html/forms/PopupMenuClient.h

index 2bd48e7f01147ebde95f2a81df0eefe7ce845d60..c1798a9f72cfd34219517488ae7beb1af5de81c8 100644

--- a/Source/core/html/forms/PopupMenuClient.h

+++ b/Source/core/html/forms/PopupMenuClient.h

@@ -54,7 +54,7 @@ public:

virtual bool itemIsLabel(unsigned listIndex) const = 0;

virtual bool itemIsSelected(unsigned listIndex) const = 0;

virtual void setTextFromItem(unsigned listIndex) = 0;

- virtual IntRect elementRectRelativeToRootView() const = 0;

+ virtual IntRect elementRectRelativeToViewport() const = 0;

virtual Element& ownerElement() const = 0;

virtual const LayoutStyle* layoutStyleForItem(Element&) const = 0;

« no previous file with comments | « Source/core/html/forms/DateTimeChooser.h ('k') | Source/core/inspector/InspectorInputAgent.cpp » ('j') | no next file with comments »