Source/web/PopupMenuImpl.cpp - Issue 919423002: Audited and renamed uses of methods and variables named RootView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/PopupMenuImpl.cpp

Issue 919423002: Audited and renamed uses of methods and variables named RootView (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Build fix Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/PopupMenuImpl.cpp

diff --git a/Source/web/PopupMenuImpl.cpp b/Source/web/PopupMenuImpl.cpp

index 40695b68b55de2c611d95c69a6b4d42226d3ba14..f687a608381575fe5a308579f7c6a68e7079cfd5 100644

--- a/Source/web/PopupMenuImpl.cpp

+++ b/Source/web/PopupMenuImpl.cpp

@@ -80,7 +80,7 @@ IntSize PopupMenuImpl::contentSize()

void PopupMenuImpl::writeDocument(SharedBuffer* data)

{

- IntRect anchorRectInScreen = m_chromeClient->rootViewToScreen(m_client->elementRectRelativeToRootView());

+ IntRect anchorRectInScreen = m_chromeClient->viewportToScreen(m_client->elementRectRelativeToViewport());

PagePopupClient::addString("<!DOCTYPE html><head><meta charset='UTF-8'><style>\n", data);

data->append(Platform::current()->loadResource("pickerCommon.css"));

@@ -266,7 +266,7 @@ void PopupMenuImpl::dispose()

void PopupMenuImpl::show(const FloatQuad& /*controlPosition*/, const IntSize& /*controlSize*/, int /*index*/)

{

ASSERT(!m_popup);

- m_popup = m_chromeClient->openPagePopup(this, m_client->elementRectRelativeToRootView());

+ m_popup = m_chromeClient->openPagePopup(this);

}

void PopupMenuImpl::hide()

« Source/core/inspector/InspectorOverlay.cpp ('K') | « Source/web/PopupContainer.cpp ('k') | Source/web/PopupMenuTest.cpp » ('j') | no next file with comments »