Source/web/ExternalDateTimeChooser.cpp - Issue 919423002: Audited and renamed uses of methods and variables named RootView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/ExternalDateTimeChooser.cpp

Issue 919423002: Audited and renamed uses of methods and variables named RootView (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Build fix Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/ExternalDateTimeChooser.cpp

diff --git a/Source/web/ExternalDateTimeChooser.cpp b/Source/web/ExternalDateTimeChooser.cpp

index f157472100999c6bdde5f159a0adcdd3ac99155a..27219055a4a89c2955bdfeb046a91f4bae36777d 100644

--- a/Source/web/ExternalDateTimeChooser.cpp

+++ b/Source/web/ExternalDateTimeChooser.cpp

@@ -110,7 +110,7 @@ bool ExternalDateTimeChooser::openDateTimeChooser(ChromeClientImpl* chromeClient

WebDateTimeChooserParams webParams;

webParams.type = toWebDateTimeInputType(parameters.type);

- webParams.anchorRectInScreen = chromeClient->rootViewToScreen(parameters.anchorRectInRootView);

+ webParams.anchorRectInScreen = chromeClient->viewportToScreen(parameters.anchorRectInScreen);

webParams.currentValue = parameters.currentValue;

webParams.doubleValue = parameters.doubleValue;

webParams.suggestions = parameters.suggestions;

« Source/core/inspector/InspectorOverlay.cpp ('K') | « Source/web/DateTimeChooserImpl.cpp ('k') | Source/web/ExternalPopupMenuTest.cpp » ('j') | no next file with comments »