Audited and renamed uses of methods and variables named RootView

Source/core/inspector/InspectorOverlay.cpp

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 93 matching lines @@
     {
         ShapePathBuilder builder(view, renderer, shapeOutsideInfo);
         builder.appendPath(path);
         return builder.path();
     }
 
 protected:
     virtual FloatPoint translatePoint(const FloatPoint& point)
     {
         FloatPoint rendererPoint = m_shapeOutsideInfo.shapeToRendererPoint(point);
-        return m_view.contentsToRootView(roundedIntPoint(m_renderer.localToAbsolute(rendererPoint)));
+        return m_view.contentsToRootFrame(roundedIntPoint(m_renderer.localToAbsolute(rendererPoint)));
     }
 
 private:
     FrameView& m_view;
     LayoutObject& m_renderer;
     const ShapeOutsideInfo& m_shapeOutsideInfo;
 };
 
 class InspectorOverlayChromeClient final: public EmptyChromeClient {
 public:
@@ skipping 107 matching lines @@
 
 private:
     bool m_showRulers;
     bool m_showExtensionLines;
     RefPtr<JSONObject> m_elementInfo;
     RefPtr<JSONArray> m_highlightPaths;
 };
 
 static void contentsQuadToScreen(const FrameView* view, FloatQuad& quad)
 {
-    quad.setP1(view->contentsToRootView(roundedIntPoint(quad.p1())));
-    quad.setP2(view->contentsToRootView(roundedIntPoint(quad.p2())));
-    quad.setP3(view->contentsToRootView(roundedIntPoint(quad.p3())));
-    quad.setP4(view->contentsToRootView(roundedIntPoint(quad.p4())));
+    // TODO: These look like they should be RootFrame, dgozman to confirm

[dgozman, 2015/02/18 14:05:58]

Situation here depends on whether WebPageOverlay is affected by viewport. If it
does, this should be toRootFrame (please rename this method to
|contentsQuadToRootFrame| then). If it doesn't, this is toViewport.

[bokan, 2015/02/18 14:10:45]

The WebPageOverlay is the highlights and size annotation over elements when
mousing over html in devtools?

+    quad.setP1(view->contentsToRootFrame(roundedIntPoint(quad.p1())));
+    quad.setP2(view->contentsToRootFrame(roundedIntPoint(quad.p2())));
+    quad.setP3(view->contentsToRootFrame(roundedIntPoint(quad.p3())));
+    quad.setP4(view->contentsToRootFrame(roundedIntPoint(quad.p4())));
 }
 
 static bool buildNodeQuads(LayoutObject* renderer, FloatQuad* content, FloatQuad* padding, FloatQuad* border, FloatQuad* margin)
 {
     FrameView* containingView = renderer->frameView();
     if (!containingView)
         return false;
     if (!renderer->isBox() && !renderer->isRenderInline())
         return false;
 
@@ skipping 567 matching lines @@
 {
     LayoutObject* renderer = node->renderer();
     FrameView* view = node->document().view();
     if (!renderer || !view)
         return false;
 
     FloatQuad content, padding, border, margin;
     if (!buildNodeQuads(node->renderer(), &content, &padding, &border, &margin))
         return false;
 
-    IntRect boundingBox = pixelSnappedIntRect(view->contentsToRootView(renderer->absoluteBoundingBoxRect()));
+    IntRect boundingBox = pixelSnappedIntRect(view->contentsToRootFrame(renderer->absoluteBoundingBoxRect()));
     RenderBoxModelObject* modelObject = renderer->isBoxModelObject() ? toRenderBoxModelObject(renderer) : nullptr;
 
     model = TypeBuilder::DOM::BoxModel::create()
         .setContent(buildArrayForQuad(content))
         .setPadding(buildArrayForQuad(padding))
         .setBorder(buildArrayForQuad(border))
         .setMargin(buildArrayForQuad(margin))
         .setWidth(modelObject ? adjustForAbsoluteZoom(modelObject->pixelSnappedOffsetWidth(), modelObject) : boundingBox.width())
         .setHeight(modelObject ? adjustForAbsoluteZoom(modelObject->pixelSnappedOffsetHeight(), modelObject) : boundingBox.height());
 
@@ skipping 45 matching lines @@
     hideHighlight();
 }
 
 void InspectorOverlay::startedRecordingProfile()
 {
     if (!m_activeProfilerCount++)
         freePage();
 }
 
 } // namespace blink