Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: print_preview_handler.cc

Issue 9194004: Merge 117361 - Print Preview: Handle a CHECK that's getting hit in PrintPreviewHandler::HandlePri... (Closed) Base URL: svn://svn.chromium.org/chrome/branches/963/src/chrome/browser/ui/webui/
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: print_preview_handler.cc
===================================================================
--- print_preview_handler.cc (revision 117588)
+++ print_preview_handler.cc (working copy)
@@ -349,11 +349,11 @@
regenerate_preview_request_count_);
TabContentsWrapper* initiator_tab = GetInitiatorTab();
- CHECK(initiator_tab);
+ if (initiator_tab) {
+ RenderViewHost* rvh = initiator_tab->render_view_host();
+ rvh->Send(new PrintMsg_ResetScriptedPrintCount(rvh->routing_id()));
+ }
- RenderViewHost* init_rvh = initiator_tab->render_view_host();
- init_rvh->Send(new PrintMsg_ResetScriptedPrintCount(init_rvh->routing_id()));
-
scoped_ptr<DictionaryValue> settings(GetSettingsDictionary(args));
if (!settings.get())
return;
@@ -420,7 +420,8 @@
RenderViewHost* rvh = web_ui_->tab_contents()->render_view_host();
rvh->Send(new PrintMsg_PrintForPrintPreview(rvh->routing_id(), *settings));
}
- initiator_tab->print_view_manager()->PrintPreviewDone();
+ if (initiator_tab)
+ initiator_tab->print_view_manager()->PrintPreviewDone();
}
void PrintPreviewHandler::HandlePrintToPdf(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698