Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 919393003: Fix a typo in components/test/data/password_manager/automated_tests/run_tests.py (Closed)

Created:
5 years, 10 months ago by vabr (Chromium)
Modified:
5 years, 10 months ago
Reviewers:
Mike West
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a typo in components/test/data/password_manager/automated_tests/run_tests.py BUG=418485 Committed: https://crrev.com/da598af72344cb67f04108e80415372bed7cea66 Cr-Commit-Position: refs/heads/master@{#316216}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M components/test/data/password_manager/automated_tests/run_tests.py View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
vabr (Chromium)
Hi Mike, Does this look good to you? Thanks, Vaclav
5 years, 10 months ago (2015-02-13 12:21:33 UTC) #2
vabr (Chromium)
P.S. Adding NOTRY=true, because this (sadly) does not affect any tests. The script is not ...
5 years, 10 months ago (2015-02-13 12:26:05 UTC) #3
Mike West
LGTM, but don't NOTRY it, or jam@ will yell at you. The bots will figure ...
5 years, 10 months ago (2015-02-13 12:58:44 UTC) #4
vabr (Chromium)
Thanks, good to know about the NOTRY, removed that. Cheers, Vaclav
5 years, 10 months ago (2015-02-13 13:07:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/919393003/1
5 years, 10 months ago (2015-02-13 13:07:37 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-13 15:12:57 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 15:13:20 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/da598af72344cb67f04108e80415372bed7cea66
Cr-Commit-Position: refs/heads/master@{#316216}

Powered by Google App Engine
This is Rietveld 408576698