Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: components/sync_driver/sync_prefs.cc

Issue 919383002: Remove some dead code about "acknowledged types" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/sync_driver/sync_prefs.h ('k') | components/sync_driver/sync_prefs_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync_driver/sync_prefs.cc
diff --git a/components/sync_driver/sync_prefs.cc b/components/sync_driver/sync_prefs.cc
index 23ccbbf93bebc7a2e6a3e131e84c11bacc8d03eb..c1c228acf077b7327b1782a7cd20bae1de86cddc 100644
--- a/components/sync_driver/sync_prefs.cc
+++ b/components/sync_driver/sync_prefs.cc
@@ -121,30 +121,6 @@ void SyncPrefs::RegisterProfilePrefs(
std::string(),
user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
- // We will start prompting people about new data types after the launch of
- // SESSIONS - all previously launched data types are treated as if they are
- // already acknowledged.
- syncer::ModelTypeSet model_set;
- model_set.Put(syncer::BOOKMARKS);
- model_set.Put(syncer::PREFERENCES);
- model_set.Put(syncer::PASSWORDS);
- model_set.Put(syncer::AUTOFILL_PROFILE);
- model_set.Put(syncer::AUTOFILL_WALLET_DATA);
- model_set.Put(syncer::AUTOFILL);
- model_set.Put(syncer::THEMES);
- model_set.Put(syncer::EXTENSIONS);
- model_set.Put(syncer::NIGORI);
- model_set.Put(syncer::SEARCH_ENGINES);
- model_set.Put(syncer::APPS);
- model_set.Put(syncer::APP_LIST);
- model_set.Put(syncer::TYPED_URLS);
- model_set.Put(syncer::SESSIONS);
- model_set.Put(syncer::ARTICLES);
- model_set.Put(syncer::WIFI_CREDENTIALS);
- registry->RegisterListPref(prefs::kSyncAcknowledgedSyncTypes,
- syncer::ModelTypeSetToValue(model_set),
- user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
-
registry->RegisterIntegerPref(
prefs::kSyncRemainingRollbackTries, 0,
user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
@@ -372,20 +348,6 @@ void SyncPrefs::SetSpareBootstrapToken(const std::string& token) {
}
#endif
-void SyncPrefs::AcknowledgeSyncedTypes(syncer::ModelTypeSet types) {
- DCHECK(CalledOnValidThread());
- // Add the types to the current set of acknowledged
- // types, and then store the resulting set in prefs.
- const syncer::ModelTypeSet acknowledged_types =
- Union(types,
- syncer::ModelTypeSetFromValue(
- *pref_service_->GetList(prefs::kSyncAcknowledgedSyncTypes)));
-
- scoped_ptr<base::ListValue> value(
- syncer::ModelTypeSetToValue(acknowledged_types));
- pref_service_->Set(prefs::kSyncAcknowledgedSyncTypes, *value);
-}
-
int SyncPrefs::GetRemainingRollbackTries() const {
return pref_service_->GetInteger(prefs::kSyncRemainingRollbackTries);
}
@@ -406,12 +368,6 @@ void SyncPrefs::SetManagedForTest(bool is_managed) {
pref_service_->SetBoolean(prefs::kSyncManaged, is_managed);
}
-syncer::ModelTypeSet SyncPrefs::GetAcknowledgeSyncedTypesForTest() const {
- DCHECK(CalledOnValidThread());
- return syncer::ModelTypeSetFromValue(
- *pref_service_->GetList(prefs::kSyncAcknowledgedSyncTypes));
-}
-
void SyncPrefs::RegisterPrefGroups() {
pref_groups_[syncer::APPS].Put(syncer::APP_NOTIFICATIONS);
pref_groups_[syncer::APPS].Put(syncer::APP_SETTINGS);
« no previous file with comments | « components/sync_driver/sync_prefs.h ('k') | components/sync_driver/sync_prefs_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698