Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 919383002: Remove some dead code about "acknowledged types" (Closed)

Created:
5 years, 10 months ago by zhuoyu.qian
Modified:
5 years, 10 months ago
Reviewers:
stanisc, maniscalco
CC:
chromium-reviews, tim+watch_chromium.org, pvalenzuela+watch_chromium.org, maxbogue+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove some dead code about "acknowledged types" Sync no longer has a concept of "acknowledged types". BUG=352818 R=stanisc@chromium.org, maniscalco@chromium.org Committed: https://crrev.com/7bacc80478c18753ae65d92b361812cc95fc9ff8 Cr-Commit-Position: refs/heads/master@{#317989}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -78 lines) Patch
M chrome/browser/sync/profile_sync_service.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.cc View 1 2 chunks +0 lines, -5 lines 0 comments Download
M components/sync_driver/pref_names.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M components/sync_driver/pref_names.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M components/sync_driver/sync_prefs.h View 2 chunks +0 lines, -4 lines 0 comments Download
M components/sync_driver/sync_prefs.cc View 1 3 chunks +0 lines, -44 lines 0 comments Download
M components/sync_driver/sync_prefs_unittest.cc View 1 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
zhuoyu.qian
5 years, 10 months ago (2015-02-13 09:00:54 UTC) #1
maniscalco
Thanks for cleaning this up! LGTM. Note, I made a small change to the commit ...
5 years, 10 months ago (2015-02-13 17:20:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/919383002/1
5 years, 10 months ago (2015-02-15 08:08:22 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja_ng/builds/10948)
5 years, 10 months ago (2015-02-15 08:10:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/919383002/20001
5 years, 10 months ago (2015-02-25 05:12:30 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-25 05:52:50 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 05:53:44 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7bacc80478c18753ae65d92b361812cc95fc9ff8
Cr-Commit-Position: refs/heads/master@{#317989}

Powered by Google App Engine
This is Rietveld 408576698