Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 919323003: Launcher: Moved placeholder text strings out of use_titlecase condition. (Closed)

Created:
5 years, 10 months ago by Matt Giuca
Modified:
5 years, 10 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@calamity-sort-results
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Launcher: Moved placeholder text strings out of use_titlecase condition. Placeholder strings should be sentence case (even when use_titlecase is enabled). This fixes the search box placeholder text which was missing "or type URL" in titlecase environments (because I forgot to update that version of the string). Also fixed some minor comma placement in some "Ok Google" strings. BUG=459537 TBR=cpu@chromium.org Committed: https://crrev.com/9993bef1acff0e10f954a0226590831b19c1519f Cr-Commit-Position: refs/heads/master@{#317003}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -13 lines) Patch
M chrome/app/generated_resources.grd View 3 chunks +7 lines, -13 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
Matt Giuca
A couple of minor string fixes.
5 years, 10 months ago (2015-02-19 02:14:38 UTC) #2
tapted
lgtm
5 years, 10 months ago (2015-02-19 04:23:06 UTC) #5
tapted
lgtm lgtm
5 years, 10 months ago (2015-02-19 04:23:06 UTC) #7
tapted
lgtm lgtm lgtm
5 years, 10 months ago (2015-02-19 04:23:07 UTC) #8
Matt Giuca
Thanks for the effusive approval!
5 years, 10 months ago (2015-02-19 05:04:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/919323003/1
5 years, 10 months ago (2015-02-19 05:05:04 UTC) #12
Matt Giuca
+cpu
5 years, 10 months ago (2015-02-19 05:06:16 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/34261)
5 years, 10 months ago (2015-02-19 06:14:49 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/919323003/1
5 years, 10 months ago (2015-02-19 06:59:57 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-19 08:05:12 UTC) #19
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 08:06:11 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9993bef1acff0e10f954a0226590831b19c1519f
Cr-Commit-Position: refs/heads/master@{#317003}

Powered by Google App Engine
This is Rietveld 408576698