Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(788)

Unified Diff: content/browser/manifest/manifest_manager_host.cc

Issue 919293002: Add related_applications field to manifest parser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review feedback Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/manifest/manifest_manager_host.cc
diff --git a/content/browser/manifest/manifest_manager_host.cc b/content/browser/manifest/manifest_manager_host.cc
index 14d07e203ee3a9b69274bfd67ca661a4a5cf10e0..501d86dd45219ca195b6539d630b740001b3e9fd 100644
--- a/content/browser/manifest/manifest_manager_host.cc
+++ b/content/browser/manifest/manifest_manager_host.cc
@@ -129,6 +129,15 @@ void ManifestManagerHost::OnRequestManifestResponse(
manifest.gcm_sender_id.string().substr(
0, Manifest::kMaxIPCStringLength),
manifest.gcm_sender_id.is_null());
+ for (size_t i = 0; i < manifest.related_applications.size(); ++i) {
Avi (use Gerrit) 2015/04/15 20:36:34 for (auto& related_app : manifest.related_applicat
benwells 2015/04/16 01:30:46 Done.
+ if (!manifest.related_applications[i].url.is_valid())
+ manifest.related_applications[i].url = GURL();
+ manifest.related_applications[i].id = base::NullableString16(
+ manifest.related_applications[i].id.string().substr(
+ 0,
+ Manifest::kMaxIPCStringLength),
+ manifest.related_applications[i].id.is_null());
+ }
callback->Run(manifest);
callbacks->Remove(request_id);
« no previous file with comments | « no previous file | content/common/manifest_manager_messages.h » ('j') | content/renderer/manifest/manifest_manager.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698