Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Unified Diff: content/browser/manifest/manifest_manager_host.cc

Issue 919293002: Add related_applications field to manifest parser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update for additions to spec Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/common/manifest_manager_messages.h » ('j') | content/public/common/manifest.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/manifest/manifest_manager_host.cc
diff --git a/content/browser/manifest/manifest_manager_host.cc b/content/browser/manifest/manifest_manager_host.cc
index 14d07e203ee3a9b69274bfd67ca661a4a5cf10e0..90a8e8f145d865b7996f08f448b0c20c075d121d 100644
--- a/content/browser/manifest/manifest_manager_host.cc
+++ b/content/browser/manifest/manifest_manager_host.cc
@@ -129,6 +129,13 @@ void ManifestManagerHost::OnRequestManifestResponse(
manifest.gcm_sender_id.string().substr(
0, Manifest::kMaxIPCStringLength),
manifest.gcm_sender_id.is_null());
+ for (size_t i = 0; i < manifest.related_applications.size(); ++i) {
+ manifest.related_applications[i].id= base::NullableString16(
mlamouri (slow - plz ping) 2015/04/10 09:49:44 nit: space before the "=".
benwells 2015/04/15 06:45:22 Done.
+ manifest.related_applications[i].id.string().substr(
+ 0,
+ Manifest::kMaxIPCStringLength),
+ manifest.related_applications[i].id.is_null());
+ }
mlamouri (slow - plz ping) 2015/04/10 09:49:44 Can you sanitize the url too?
benwells 2015/04/15 06:45:22 Done.
callback->Run(manifest);
callbacks->Remove(request_id);
« no previous file with comments | « no previous file | content/common/manifest_manager_messages.h » ('j') | content/public/common/manifest.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698