Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1172)

Unified Diff: content/public/common/manifest.cc

Issue 919293002: Add related_applications field to manifest parser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/common/manifest.cc
diff --git a/content/public/common/manifest.cc b/content/public/common/manifest.cc
index 389754189cecbc5713782cd182839a1e5a2bc8bf..0f68d7de4dbd9b6cb0f6c4b64c3f70215d908fff 100644
--- a/content/public/common/manifest.cc
+++ b/content/public/common/manifest.cc
@@ -16,6 +16,13 @@ Manifest::Icon::Icon()
Manifest::Icon::~Icon() {
}
+Manifest::RelatedApplication::RelatedApplication()
+ : platform(RELATED_APPLICATION_PLATFORM_UNSPECIFIED) {
+}
+
+Manifest::RelatedApplication::~RelatedApplication() {
+}
+
Manifest::Manifest()
: display(DISPLAY_MODE_UNSPECIFIED),
orientation(blink::WebScreenOrientationLockDefault),
@@ -26,14 +33,11 @@ Manifest::~Manifest() {
}
bool Manifest::IsEmpty() const {
- return name.is_null() &&
- short_name.is_null() &&
- start_url.is_empty() &&
+ return name.is_null() && short_name.is_null() && start_url.is_empty() &&
display == DISPLAY_MODE_UNSPECIFIED &&
orientation == blink::WebScreenOrientationLockDefault &&
- icons.empty() &&
- gcm_sender_id.is_null() &&
- !gcm_user_visible_only;
+ icons.empty() && gcm_sender_id.is_null() && !gcm_user_visible_only &&
+ chrome_related_applications.empty();
benwells 2015/02/13 05:42:37 Hmmm this was git cl format. I can put it back as
mlamouri (slow - plz ping) 2015/02/16 20:20:39 Please :) `git cl format` knows nothing about read
benwells 2015/02/16 23:58:43 Done.
}
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698