Handle an extension printer supporting only PWG raster data

Handle an extension printer supporting only PWG raster data

If an extension printer does not declare support for PDF in its
capabilities, convert print data to PWG raster before dispatching
print request to the extension.

BUG=408772
Committed: https://crrev.com/4df4bf62db39f76f09f0b5600594d02fe4169641
Cr-Commit-Position: refs/heads/master@{#317012}

[tbarzic, 2015-02-13 01:12:18]

Patchset #2 (id:20001) has been deleted

[tbarzic, 2015-02-13 03:02:58]

tbarzic@chromium.org changed reviewers:
+ vitalybuka@chromium.org

[tbarzic, 2015-02-13 03:08:13]

https://codereview.chromium.org/919213002/diff/80001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/print_preview/extension_printer_handler.h (right):

https://codereview.chromium.org/919213002/diff/80001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/print_preview/extension_printer_handler.h:101: #if
defined(ENABLE_SERVICE_DISCOVERY)
actually, looking at chrome_browser_gypi, this is included when
enable_print_preview == 1, so I guess ifdef is not really needed?

[Vitaly Buka (NO REVIEWS), 2015-02-17 19:43:54]

https://codereview.chromium.org/919213002/diff/80001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/print_preview/extension_printer_handler.h (right):

https://codereview.chromium.org/919213002/diff/80001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/print_preview/extension_printer_handler.h:101: #if
defined(ENABLE_SERVICE_DISCOVERY)
On 2015/02/13 03:08:13, tbarzic wrote:
> actually, looking at chrome_browser_gypi, this is included when
> enable_print_preview == 1, so I guess ifdef is not really needed?
ok

https://codereview.chromium.org/919213002/diff/50005/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/print_preview/extension_printer_handler.cc (right):

https://codereview.chromium.org/919213002/diff/50005/chrome/browser/ui/webui/...
chrome/browser/ui/webui/print_preview/extension_printer_handler.cc:69:
base::WorkerPool::GetTaskRunner(true)->PostTask(
PostTaskAndReplyWithResult is appropriate here

https://codereview.chromium.org/919213002/diff/50005/chrome/browser/ui/webui/...
chrome/browser/ui/webui/print_preview/extension_printer_handler.cc:148: const
gfx::Size& size,
looks like this code is very similar to privet version. Can we avoid code
duplication here?

https://codereview.chromium.org/919213002/diff/50005/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/print_preview/printer_handler.h (right):

https://codereview.chromium.org/919213002/diff/50005/chrome/browser/ui/webui/...
chrome/browser/ui/webui/print_preview/printer_handler.h:71: const gfx::Size&
size,
size is a property of document, ideally we need to get it from there.
it's even invalid with multi-sized pdfs. Can you drop some TODO about that?

maybe TODO(): get source size from print_data.

[tbarzic, 2015-02-18 02:55:50]

https://codereview.chromium.org/919213002/diff/50005/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/print_preview/extension_printer_handler.cc (right):

https://codereview.chromium.org/919213002/diff/50005/chrome/browser/ui/webui/...
chrome/browser/ui/webui/print_preview/extension_printer_handler.cc:69:
base::WorkerPool::GetTaskRunner(true)->PostTask(
On 2015/02/17 19:43:54, Vitaly Buka wrote:
> PostTaskAndReplyWithResult is appropriate here

Done.

https://codereview.chromium.org/919213002/diff/50005/chrome/browser/ui/webui/...
chrome/browser/ui/webui/print_preview/extension_printer_handler.cc:148: const
gfx::Size& size,
On 2015/02/17 19:43:54, Vitaly Buka wrote:
> looks like this code is very similar to privet version. Can we avoid code
> duplication here?

Yeah, meant to do that before sending the cl for review, but forgot about it.
Also, I'm missing piece that fills out PwgRasterSettings passed to the
converter.

Moved this part to a separate cl:
https://codereview.chromium.org/935673004/

https://codereview.chromium.org/919213002/diff/50005/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/print_preview/printer_handler.h (right):

https://codereview.chromium.org/919213002/diff/50005/chrome/browser/ui/webui/...
chrome/browser/ui/webui/print_preview/printer_handler.h:71: const gfx::Size&
size,
On 2015/02/17 19:43:54, Vitaly Buka wrote:
> size is a property of document, ideally we need to get it from there.
> it's even invalid with multi-sized pdfs. Can you drop some TODO about that?
> 
> maybe TODO(): get source size from print_data.

So, basically, the page size should be extracted from document data when
processing a page in PDFiumEngineExports::RenderPDFPageToBitmap (and then used
to calculate the bitmap size), right?

Added TODO, and also renamed it to |page_size|, to be less vague.

[Vitaly Buka (NO REVIEWS), 2015-02-18 20:00:58]

https://codereview.chromium.org/919213002/diff/190001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/print_preview/extension_printer_handler.cc (right):

https://codereview.chromium.org/919213002/diff/190001/chrome/browser/ui/webui...
chrome/browser/ui/webui/print_preview/extension_printer_handler.cc:64:
base::WorkerPool::GetTaskRunner(true)->PostTaskAndReply(
I thought about 
scoped_refptr<base::RefCountedString> ReadConvertedPWGRasterFileOnWorkerThread {
return new_data;
}

and base::PostTaskAndReplyWithResult()

Swapping data const result is a hack.

[tbarzic, 2015-02-18 20:37:03]

https://codereview.chromium.org/919213002/diff/190001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/print_preview/extension_printer_handler.cc (right):

https://codereview.chromium.org/919213002/diff/190001/chrome/browser/ui/webui...
chrome/browser/ui/webui/print_preview/extension_printer_handler.cc:64:
base::WorkerPool::GetTaskRunner(true)->PostTaskAndReply(
On 2015/02/18 20:00:57, Vitaly Buka wrote:
> I thought about 
> scoped_refptr<base::RefCountedString> ReadConvertedPWGRasterFileOnWorkerThread
{
> return new_data;
> }
> 
> and base::PostTaskAndReplyWithResult()
> 
> Swapping data const result is a hack.

D'oh, I forgot we have that method :/

[tbarzic, 2015-02-18 20:37:35]

https://codereview.chromium.org/919213002/diff/190001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/print_preview/extension_printer_handler.cc (right):

https://codereview.chromium.org/919213002/diff/190001/chrome/browser/ui/webui...
chrome/browser/ui/webui/print_preview/extension_printer_handler.cc:64:
base::WorkerPool::GetTaskRunner(true)->PostTaskAndReply(
On 2015/02/18 20:37:03, tbarzic wrote:
> On 2015/02/18 20:00:57, Vitaly Buka wrote:
> > I thought about 
> > scoped_refptr<base::RefCountedString>
ReadConvertedPWGRasterFileOnWorkerThread
> {
> > return new_data;
> > }
> > 
> > and base::PostTaskAndReplyWithResult()
> > 
> > Swapping data const result is a hack.
> 
> D'oh, I forgot we have that method :/

Done.

[Vitaly Buka (NO REVIEWS), 2015-02-18 23:38:24]

The CQ bit was checked by vitalybuka@chromium.org

[Vitaly Buka (NO REVIEWS), 2015-02-18 23:38:24]

lgtm

[commit-bot: I haz the power, 2015-02-18 23:41:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/919213002/250001

[tbarzic, 2015-02-18 23:44:15]

The CQ bit was unchecked by tbarzic@chromium.org

[tbarzic, 2015-02-19 04:45:29]

The CQ bit was checked by tbarzic@chromium.org

[commit-bot: I haz the power, 2015-02-19 04:46:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/919213002/250001

[commit-bot: I haz the power, 2015-02-19 05:54:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-19 05:54:08]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tbarzic, 2015-02-19 06:05:21]

The CQ bit was checked by tbarzic@chromium.org

[commit-bot: I haz the power, 2015-02-19 06:06:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/919213002/250001

[commit-bot: I haz the power, 2015-02-19 07:11:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-19 07:11:49]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Vitaly Buka (NO REVIEWS), 2015-02-19 08:07:37]

The CQ bit was checked by vitalybuka@chromium.org

[commit-bot: I haz the power, 2015-02-19 08:08:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/919213002/250001

[commit-bot: I haz the power, 2015-02-19 08:45:04]

Committed patchset #13 (id:250001)

[commit-bot: I haz the power, 2015-02-19 08:45:31]

Patchset 13 (id:??) landed as
https://crrev.com/4df4bf62db39f76f09f0b5600594d02fe4169641
Cr-Commit-Position: refs/heads/master@{#317012}