Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 919173003: During arguments materialization, do not store materialized objects without lazy deopt. (Closed)

Created:
5 years, 10 months ago by Jarin
Modified:
5 years, 10 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

During arguments materialization, do not store materialized objects without lazy deopt. BUG= R=mstarzinger@chromium.org Committed: https://crrev.com/0a4047a69b0f2b4b16d0a79f4c4db2aec506c18d Cr-Commit-Position: refs/heads/master@{#26695}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -13 lines) Patch
M src/deoptimizer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/deoptimizer.cc View 5 chunks +11 lines, -7 lines 0 comments Download
A + test/mjsunit/regress/regress-arg-materialize-store.js View 1 chunk +12 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Jarin
Could you take a look, please?
5 years, 10 months ago (2015-02-17 15:00:35 UTC) #1
Michael Starzinger
LGTM.
5 years, 10 months ago (2015-02-17 15:08:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/919173003/1
5 years, 10 months ago (2015-02-17 15:17:20 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-17 15:24:33 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 15:24:45 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0a4047a69b0f2b4b16d0a79f4c4db2aec506c18d
Cr-Commit-Position: refs/heads/master@{#26695}

Powered by Google App Engine
This is Rietveld 408576698