Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 919153003: Update SkiaBenchmarking for upcoming Skia changes (Closed)

Created:
5 years, 10 months ago by robertphillips
Modified:
5 years, 10 months ago
Reviewers:
jvanverth1, no sievers
CC:
chromium-reviews, extensions-reviews_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update SkiaBenchmarking for upcoming Skia changes Skia's SkDrawCommand will be changing. This CL prepares Chromium's unit test for the upcoming changes. BUG=457691 Committed: https://crrev.com/c25e09cb403ef31802ad6fdcacdbfbe123565980 Cr-Commit-Position: refs/heads/master@{#316230}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/renderer/skia_benchmarking_extension.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
robertphillips
Missed a variable :(
5 years, 10 months ago (2015-02-12 22:12:29 UTC) #2
no sievers
lgtm
5 years, 10 months ago (2015-02-12 23:18:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/919153003/1
5 years, 10 months ago (2015-02-13 14:43:37 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/24813)
5 years, 10 months ago (2015-02-13 15:53:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/919153003/1
5 years, 10 months ago (2015-02-13 16:12:18 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-13 17:11:46 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 17:12:19 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c25e09cb403ef31802ad6fdcacdbfbe123565980
Cr-Commit-Position: refs/heads/master@{#316230}

Powered by Google App Engine
This is Rietveld 408576698