Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 919023003: DNSDomainFromDot: Reject empty labels. (Closed)

Created:
5 years, 10 months ago by Deprecated (see juliatuttle)
Modified:
5 years, 9 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DNSDomainFromDot: Reject empty labels. Don't allow empty labels in DNS names (".example.domain.com" or "google..com"). BUG=456391 Committed: https://crrev.com/c7f5ee53e3b82696a75bfbde7474af9a696aa9c3 Cr-Commit-Position: refs/heads/master@{#319542}

Patch Set 1 #

Patch Set 2 : Also reject domain with trailing dot. #

Patch Set 3 : Allow trailing dot (disables suffix search); make sure name parses before calling getaddrinfo #

Patch Set 4 : Don't append spurious empty label. #

Patch Set 5 : rebase #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -15 lines) Patch
M net/base/dns_util.cc View 1 2 3 2 chunks +10 lines, -8 lines 0 comments Download
M net/base/dns_util_unittest.cc View 1 2 1 chunk +5 lines, -7 lines 0 comments Download
M net/dns/host_resolver_proc.cc View 1 2 2 chunks +8 lines, -0 lines 1 comment Download

Messages

Total messages: 11 (4 generated)
Deprecated (see juliatuttle)
PTAL, rsleevi.
5 years, 9 months ago (2015-03-03 15:31:33 UTC) #2
Ryan Sleevi
LGTM % nit Sorry for the delay, I've been hunting down interop issues on this. ...
5 years, 9 months ago (2015-03-06 22:11:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/919023003/80001
5 years, 9 months ago (2015-03-06 22:36:29 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) mac_chromium_rel_ng on ...
5 years, 9 months ago (2015-03-07 00:38:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/919023003/80001
5 years, 9 months ago (2015-03-07 01:42:41 UTC) #9
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 9 months ago (2015-03-07 01:44:12 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-07 01:44:45 UTC) #11
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/c7f5ee53e3b82696a75bfbde7474af9a696aa9c3
Cr-Commit-Position: refs/heads/master@{#319542}

Powered by Google App Engine
This is Rietveld 408576698