Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: tools/release/auto_roll.py

Issue 918953003: Include range summary when rolling into chromium. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/release/chromium_roll.py » ('j') | tools/release/chromium_roll.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/release/auto_roll.py
diff --git a/tools/release/auto_roll.py b/tools/release/auto_roll.py
index 2cba6af4fb9dbf39166d16a43c9b07e52b2c5c2e..315a4bc2a0a16f18863fbc85109fb5aae50664bc 100755
--- a/tools/release/auto_roll.py
+++ b/tools/release/auto_roll.py
@@ -52,7 +52,7 @@ class DetectLastRoll(Step):
exec(FileToText(os.path.join(self._options.chromium, "DEPS")))
# The revision rolled last.
- last_roll = vars['v8_revision']
+ self["last_roll"] = vars['v8_revision']
# TODO(machenbach): It is possible that the auto-push script made a new
# fast-forward release (e.g. 4.2.3) while somebody patches the last
@@ -60,11 +60,11 @@ class DetectLastRoll(Step):
# the fast-forward release. Should there be a way to prioritize the
# patched version?
- if latest_release == last_roll:
+ if latest_release == self["last_roll"]:
# We always try to roll if the latest revision is not the revision in
# chromium.
print("There is no newer v8 revision than the one in Chromium (%s)."
- % last_roll)
+ % self["last_roll"])
return True
@@ -95,6 +95,7 @@ class RollChromium(Step):
"--author", self._options.author,
"--reviewer", self._options.reviewer,
"--chromium", self._options.chromium,
+ "--last-roll", self["last_roll"],
"--use-commit-queue",
]
if self._options.sheriff:
« no previous file with comments | « no previous file | tools/release/chromium_roll.py » ('j') | tools/release/chromium_roll.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698