Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: chrome/test/data/pdf/navigator_test.js

Issue 918953002: Fix for PDFs with lots of named destinations take a long time to load. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes with new approach. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/pdf/navigator_test.js
diff --git a/chrome/test/data/pdf/navigator_test.js b/chrome/test/data/pdf/navigator_test.js
index d068a96ec81dc350ff6995ff313a7fdb8dc36b4b..8e4fcfa4591b19c9fc29d227a3479408aae85eaa 100644
--- a/chrome/test/data/pdf/navigator_test.js
+++ b/chrome/test/data/pdf/navigator_test.js
@@ -76,18 +76,6 @@ var tests = [
chrome.test.assertEq(0, viewport.position.x);
chrome.test.assertEq(300, viewport.position.y);
- mockCallback.reset();
- navigateInCurrentTabCallback.reset();
- // #ABC is not a named destination in the page so viewport should not
- // update and viewport position should remain same. As this link will open
- // in the same tab.
- navigator.navigate(url + "#ABC", false);
- chrome.test.assertFalse(mockCallback.wasCalled);
- chrome.test.assertTrue(
- navigateInCurrentTabCallback.navigateInCurrentTabCalled);
- chrome.test.assertEq(0, viewport.position.x);
- chrome.test.assertEq(300, viewport.position.y);
raymes 2015/02/16 02:02:31 How come this is removed?
Deepak 2015/02/16 06:45:38 This is removed as: when #ABC is not in paramsPars
raymes 2015/02/16 22:44:03 If we do the suggestion above we should be able to
-
chrome.test.succeed();
}
];

Powered by Google App Engine
This is Rietveld 408576698