Fix for PDFs with lots of named destinations take a long time to load.

chrome/browser/resources/pdf/pdf.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /**
  * @return {number} Width of a scrollbar in pixels
  */
 function getScrollbarWidth() {
@@ skipping 172 matching lines @@
                                zoomChangeInfo.newZoomFactor);
       // We should not change zoom level when we are responsible for initiating
       // the zoom. onZoomChange() is called before setZoomComplete() callback
       // when we initiate the zoom.
       if ((zoomDelta > MIN_ZOOM_DELTA) && !this.setZoomInProgress_)
         this.viewport_.setZoom(zoomChangeInfo.newZoomFactor);
     }.bind(this));
   }
 
   // Parse open pdf parameters.
-  this.paramsParser_ = new OpenPDFParamsParser();
+  this.paramsParser_ =
+      new OpenPDFParamsParser(this.getNamedDestination_.bind(this));
   this.navigator_ = new Navigator(this.streamDetails_.originalUrl,
-      this.viewport_, this.paramsParser_, onNavigateInCurrentTab,
-      onNavigateInNewTab);
+                                  this.viewport_, this.paramsParser_,
+                                  onNavigateInCurrentTab, onNavigateInNewTab);
   this.viewportScroller_ =
       new ViewportScroller(this.viewport_, this.plugin_, window);
 }
 
 PDFViewer.prototype = {
   /**
    * @private
    * Handle key events. These may come from the user directly or via the
    * scripting API.
    * @param {KeyboardEvent} e the event to handle.
@@ skipping 136 matching lines @@
   rotateCounterClockwise_: function() {
     this.plugin_.postMessage({
       type: 'rotateCounterclockwise'
     });
   },
 
   /**
    * @private
    * Notify the plugin to print.
    */
-  print_: function() { this.plugin_.postMessage({type: 'print'}); },
+  print_: function() {
+    this.plugin_.postMessage({
+      type: 'print'
+    });
+  },
 
   /**
    * @private
    * Notify the plugin to save.
    */
-  save_: function() { this.plugin_.postMessage({type: 'save'}); },
+  save_: function() {
+    this.plugin_.postMessage({
+      type: 'save'
+    });
+  },
+
+  /**
+   * Fetches the page number corresponding to the given named destination from
+   * the plugin.
+   * @param {string} name The namedDestination to fetch page number from plugin.
+   */
+  getNamedDestination_: function(name) {
+    this.plugin_.postMessage({
+      type: 'getNamedDestination',
+      namedDestination: name
+    });
+  },
 
   /**
    * @private
    * Handle open pdf parameters. This function updates the viewport as per
    * the parameters mentioned in the url while opening pdf. The order is
    * important as later actions can override the effects of previous actions.
    */
-  handleURLParams_: function() {
-    var urlParams =
-        this.paramsParser_.getViewportFromUrlParams(
-            this.streamDetails_.originalUrl);
-    if (urlParams.page)
-      this.viewport_.goToPage(urlParams.page);
-    if (urlParams.position) {
+  handleURLParams_: function(viewportPosition) {
+    if (viewportPosition.page != undefined)
+      this.viewport_.goToPage(viewportPosition.page);
+    if (viewportPosition.position) {
       // Make sure we don't cancel effect of page parameter.
       this.viewport_.position = {
-        x: this.viewport_.position.x + urlParams.position.x,
-        y: this.viewport_.position.y + urlParams.position.y
+        x: this.viewport_.position.x + viewportPosition.position.x,
+        y: this.viewport_.position.y + viewportPosition.position.y
       };
     }
-    if (urlParams.zoom)
-      this.viewport_.setZoom(urlParams.zoom);
+    if (viewportPosition.zoom)
+      this.viewport_.setZoom(viewportPosition.zoom);
   },
 
   /**
    * @private
    * Update the loading progress of the document in response to a progress
    * message being received from the plugin.
    * @param {number} progress the progress as a percentage.
    */
   updateProgress_: function(progress) {
     if (this.isMaterial_)
       this.materialToolbar_.loadProgress = progress;
     else
       this.progressBar_.progress = progress;
 
     if (progress == -1) {
       // Document load failed.
       this.errorScreen_.style.visibility = 'visible';
       this.sizer_.style.display = 'none';
       this.toolbar_.style.visibility = 'hidden';
       if (this.passwordScreen_.active) {
         this.passwordScreen_.deny();
         this.passwordScreen_.active = false;
       }
     } else if (progress == 100) {
       // Document load complete.
       if (this.lastViewportPosition_)
         this.viewport_.position = this.lastViewportPosition_;
-      this.handleURLParams_();
+      this.paramsParser_.getViewportFromUrlParams(
+        this.streamDetails_.originalUrl, this.handleURLParams_.bind(this));

[raymes, 2015/02/16 22:44:04]

nit: 4 space indent

[Deepak, 2015/02/17 07:12:12]

Done.

       this.loaded_ = true;
       this.sendScriptingMessage_({
         type: 'documentLoaded'
       });
       while (this.delayedScriptingMessages_.length > 0)
         this.handleScriptingMessage(this.delayedScriptingMessages_.shift());
     }
   },
 
   /**
@@ skipping 59 matching lines @@
       case 'loadProgress':
         this.updateProgress_(message.data.progress);
         break;
       case 'navigate':
         // If in print preview, always open a new tab.
         if (this.isPrintPreview_)
           this.navigator_.navigate(message.data.url, true);
         else
           this.navigator_.navigate(message.data.url, message.data.newTab);
         break;
-      case 'setNamedDestinations':
-        this.paramsParser_.namedDestinations = message.data.namedDestinations;
-        break;
       case 'setScrollPosition':
         var position = this.viewport_.position;
         if (message.data.x !== undefined)
           position.x = message.data.x;
         if (message.data.y !== undefined)
           position.y = message.data.y;
         this.viewport_.position = position;
         break;
       case 'setTranslatedStrings':
         this.passwordScreen_.text = message.data.getPasswordString;
@@ skipping 10 matching lines @@
       case 'bookmarks':
         this.bookmarks_ = message.data.bookmarks;
         if (this.isMaterial_ && this.bookmarks_.length !== 0) {
           $('bookmarks-container').bookmarks = this.bookmarks;
           this.materialToolbar_.hasBookmarks = true;
         }
         break;
       case 'setIsSelecting':
         this.viewportScroller_.setEnableScrolling(message.data.isSelecting);
         break;
+      case 'getNamedDestinationReply':
+        this.paramsParser_.onNamedDestinationReceived(
+            message.data.namedDestinationPageNumber);
+        break;
     }
   },
 
   /**
    * @private
    * A callback that's called before the zoom changes. Notify the plugin to stop
    * reacting to scroll events while zoom is taking place to avoid flickering.
    */
   beforeZoom_: function() {
     this.plugin_.postMessage({
@@ skipping 226 matching lines @@
    * Each bookmark is an Object containing a:
    * - title
    * - page (optional)
    * - array of children (themselves bookmarks)
    * @type {Array} the top-level bookmarks of the PDF.
    */
   get bookmarks() {
     return this.bookmarks_;
   }
 };