Fix for PDFs with lots of named destinations take a long time to load.

pdf/out_of_process_instance.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "pdf/out_of_process_instance.h"
 
 #include <algorithm>  // for min/max()
 #define _USE_MATH_DEFINES  // for M_PI
 #include <cmath>      // for log() and pow()
 #include <math.h>
@@ skipping 122 matching lines @@
 const char kJSRotateClockwiseType[] = "rotateClockwise";
 const char kJSRotateCounterclockwiseType[] = "rotateCounterclockwise";
 // Select all text in the document (Page -> Plugin)
 const char kJSSelectAllType[] = "selectAll";
 // Get the selected text in the document (Page -> Plugin)
 const char kJSGetSelectedTextType[] = "getSelectedText";
 // Reply with selected text (Plugin -> Page)
 const char kJSGetSelectedTextReplyType[] = "getSelectedTextReply";
 const char kJSSelectedText[] = "selectedText";
 
-// List of named destinations (Plugin -> Page)
-const char kJSSetNamedDestinationsType[] = "setNamedDestinations";
-const char kJSNamedDestinations[] = "namedDestinations";
+// Get the named destinations (Page -> Plugin)

[raymes, 2015/02/16 02:02:31]

nit: Get the named destination with the given name (Page -> Plugin)

[Deepak, 2015/02/16 06:45:38]

Done.

+const char KJSGetNamedDestinationType[] = "getNamedDestination";
+const char KJSGetNamedDestination[] = "namedDestination";
+// Reply with page number of named destination (Plugin -> Page)

[raymes, 2015/02/16 02:02:31]

nit: Reply with the page number of the named destination (Plugin -> Page)

[Deepak, 2015/02/16 06:45:38]

Done.

+const char kJSGetNamedDestinationReplyType[] = "getNamedDestinationReply";
+const char kJSNamedDestinationPageNumber[] = "namedDestinationPageNumber";
 
 // Selecting text in document (Plugin -> Page)
 const char kJSSetIsSelectingType[] = "setIsSelecting";
 const char kJSIsSelecting[] = "isSelecting";
 
 const int kFindResultCooldownMs = 100;
 
 const double kMinZoom = 0.01;
 
 namespace {
@@ skipping 317 matching lines @@
   } else if (type == kJSStopScrollingType) {
     stop_scrolling_ = true;
   } else if (type == kJSGetSelectedTextType) {
     std::string selected_text = engine_->GetSelectedText();
     // Always return unix newlines to JS.
     base::ReplaceChars(selected_text, "\r", std::string(), &selected_text);
     pp::VarDictionary reply;
     reply.Set(pp::Var(kType), pp::Var(kJSGetSelectedTextReplyType));
     reply.Set(pp::Var(kJSSelectedText), selected_text);
     PostMessage(reply);
+  } else if (type == KJSGetNamedDestinationType &&
+             dict.Get(pp::Var(KJSGetNamedDestination)).is_string()) {
+    int page_number = engine_->GetNamedDestinationPage(
+        dict.Get(pp::Var(KJSGetNamedDestination)).AsString());
+    pp::VarDictionary reply;
+    reply.Set(pp::Var(kType), pp::Var(kJSGetNamedDestinationReplyType));
+    if (page_number >= 0)
+      reply.Set(pp::Var(kJSNamedDestinationPageNumber), page_number);
+    PostMessage(reply);
   } else {
     NOTREACHED();
   }
 }
 
 bool OutOfProcessInstance::HandleInputEvent(
     const pp::InputEvent& event) {
   // To simplify things, convert the event into device coordinates if it is
   // a mouse event.
   pp::InputEvent event_device_res(event);
@@ skipping 595 matching lines @@
   document_load_state_ = LOAD_STATE_COMPLETE;
   UserMetricsRecordAction("PDF.LoadSuccess");
 
   // Note: If we are in print preview mode the scroll location is retained
   // across document loads so we don't want to scroll again and override it.
   if (IsPrintPreview()) {
     AppendBlankPrintPreviewPages();
     OnGeometryChanged(0, 0);
   }
 
-  pp::VarDictionary named_destinations_message;
-  pp::VarDictionary named_destinations = engine_->GetNamedDestinations();

[raymes, 2015/02/16 02:02:31]

nit: This function is now unused, let's remove it entirely

[Deepak, 2015/02/16 06:45:38]

Done.

-  named_destinations_message.Set(pp::Var(kType),
-                                 pp::Var(kJSSetNamedDestinationsType));
-  named_destinations_message.Set(pp::Var(kJSNamedDestinations),
-                                 pp::Var(named_destinations));
-  PostMessage(named_destinations_message);
-
   pp::VarDictionary bookmarks_message;
   bookmarks_message.Set(pp::Var(kType), pp::Var(kJSBookmarksType));
   bookmarks_message.Set(pp::Var(kJSBookmarks), engine_->GetBookmarks());
   PostMessage(bookmarks_message);
 
   pp::VarDictionary progress_message;
   progress_message.Set(pp::Var(kType), pp::Var(kJSLoadProgressType));
   progress_message.Set(pp::Var(kJSProgressPercentage), pp::Var(100));
   PostMessage(progress_message);
 
@@ skipping 287 matching lines @@
 pp::FloatPoint OutOfProcessInstance::BoundScrollOffsetToDocument(
     const pp::FloatPoint& scroll_offset) {
   float max_x = document_size_.width() * zoom_ - plugin_dip_size_.width();
   float x = std::max(std::min(scroll_offset.x(), max_x), 0.0f);
   float max_y = document_size_.height() * zoom_ - plugin_dip_size_.height();
   float y = std::max(std::min(scroll_offset.y(), max_y), 0.0f);
   return pp::FloatPoint(x, y);
 }
 
 }  // namespace chrome_pdf