Fix for PDFs with lots of named destinations take a long time to load.

chrome/test/data/pdf/navigator_test.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 function NavigateInCurrentTabCallback() {
   this.navigateInCurrentTabCalled = false;
   this.callback = function() {
     this.navigateInCurrentTabCalled = true;
   }.bind(this);
   this.reset = function() {
@@ skipping 18 matching lines @@
    */
   function testNavigate() {
     var mockWindow = new MockWindow(100, 100);
     var mockSizer = new MockSizer();
     var mockCallback = new MockViewportChangedCallback();
     var viewport = new Viewport(mockWindow, mockSizer, mockCallback.callback,
                                 function() {}, function() {}, 0, 0);
 
     var paramsParser = new OpenPDFParamsParser();
     paramsParser.namedDestinations['US'] = 0;
     paramsParser.namedDestinations['UY'] = 2;

[raymes, 2015/02/16 22:44:03]

instead, we should pass in the function to get the named destination which would
simply call onNamedDestinationReceived with the correct value.

     var url = "http://xyz.pdf";
 
     var navigateInCurrentTabCallback = new NavigateInCurrentTabCallback();
     var navigateInNewTabCallback = new NavigateInNewTabCallback();
     var navigator = new Navigator(url, viewport, paramsParser,
         navigateInCurrentTabCallback.callback,
         navigateInNewTabCallback.callback);
 
     var documentDimensions = new MockDocumentDimensions();
     documentDimensions.addPage(100, 100);
@@ skipping 19 matching lines @@
     chrome.test.assertEq(0, viewport.position.x);
     chrome.test.assertEq(0, viewport.position.y);
 
     mockCallback.reset();
     // This should move viewport to page 2.
     navigator.navigate(url + "#UY", false);
     chrome.test.assertTrue(mockCallback.wasCalled);
     chrome.test.assertEq(0, viewport.position.x);
     chrome.test.assertEq(300, viewport.position.y);
 
-    mockCallback.reset();
-    navigateInCurrentTabCallback.reset();
-    // #ABC is not a named destination in the page so viewport should not
-    // update and viewport position should remain same. As this link will open
-    // in the same tab.
-    navigator.navigate(url + "#ABC", false);
-    chrome.test.assertFalse(mockCallback.wasCalled);
-    chrome.test.assertTrue(
-        navigateInCurrentTabCallback.navigateInCurrentTabCalled);
-    chrome.test.assertEq(0, viewport.position.x);
-    chrome.test.assertEq(300, viewport.position.y);

[raymes, 2015/02/16 02:02:31]

How come this is removed?

[Deepak, 2015/02/16 06:45:38]

This is removed as:
when #ABC is not in paramsParser.namedDestinations.
so then it will fetch that #ABC from the plugin, via
getNamedDestinationFunction_() that function is provided by pdfviewer while
making OpenPDFParamsParser object.

Even if we provide this function while creating OpenPDFParamsParser() then this
callback will get called, and navigator callback will not receive call as that
will happen after receiving message from plugin.
So this case is not relevant here.

[raymes, 2015/02/16 22:44:03]

If we do the suggestion above we should be able to keep this test.

-
     chrome.test.succeed();
   }
 ];
 
 var scriptingAPI = new PDFScriptingAPI(window, window);
 scriptingAPI.setLoadCallback(function() {
   chrome.test.runTests(tests);
 });