ui/webui/resources/cr_elements/cr_input/cr_input.html - Issue 918913002: Add a <cr-input> element to cr_elements.

Side by Side Diff: ui/webui/resources/cr_elements/cr_input/cr_input.html

Issue 918913002: Add a <cr-input> element to cr_elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/md_settings/md_settings.html ('K') | « ui/webui/resources/cr_elements/cr_input/cr_input.css ('k') | ui/webui/resources/cr_elements/cr_input/cr_input.js » ('j') | ui/webui/resources/cr_elements/cr_input/cr_input.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/polymer/polymer/polymer.html">

	2 <link rel="import"

	3 href="chrome://resources/polymer/paper-input/paper-input-decorator.html">

	4 <link rel="import" href="chrome://resources/polymer/core-input/core-input.html">

	5 <link rel="import" href="chrome://resources/cr_elements/cr_events/cr_events.html ">
	michaelpg 2015/02/13 00:08:29 nit: let's be consistent in wrapping nit: let's be consistent in wrapping Jeremy Klein 2015/02/13 00:22:54 Done. Show quoted text On 2015/02/13 00:08:29, michaelpg wrote: > nit: let's be consistent in wrapping Done.
	6

	7 <polymer-element name="cr-input">

	8 <template>

	9 <link rel="stylesheet" href="cr_input.css">

	10 <cr-events id="events"></cr-events>

	11

	12 <paper-input-decorator id="decorator" label="{{label}}" floatingLabel="{{flo atingLabel}}"
	michaelpg 2015/02/13 00:08:28 nit: 12, 14, 15 should be limited to 80 chars wide nit: 12, 14, 15 should be limited to 80 chars wide michaelpg 2015/02/13 00:08:29 we use {{ spaces }} inside data-binding braces we use {{ spaces }} inside data-binding braces Jeremy Klein 2015/02/13 00:22:54 Where did this convention come from? This isn't do Show quoted text On 2015/02/13 00:08:29, michaelpg wrote: > we use {{ spaces }} inside data-binding braces Where did this convention come from? This isn't done in any of the core/paper elements. Happy to change it, but when was this decision made? Jeremy Klein 2015/02/13 00:22:55 Waiting on verification about 80-char limit. If we Show quoted text On 2015/02/13 00:08:28, michaelpg wrote: > nit: 12, 14, 15 should be limited to 80 chars wide Waiting on verification about 80-char limit. If we need it, I'll also need to change the imports. michaelpg 2015/02/13 05:45:13 Hmm, I guess the truth is I use {{ spaces }} ins Show quoted text On 2015/02/13 00:22:54, Jeremy Klein wrote: > On 2015/02/13 00:08:29, michaelpg wrote: > > we use {{ spaces }} inside data-binding braces > > Where did this convention come from? This isn't done in any of the core/paper > elements. Happy to change it, but when was this decision made? Hmm, I guess the truth is I use {{ spaces }} inside the braces. I guess we should stick with the Polymer style of not using spaces, so this is good as-is. 1. Polymer files (third_party/Polymer/) don't use spaces: {{label}} 2. non-infra Chrome doesn't use spaces: {{label}} (19 files out of 23, not counting cr-toggle-button for now) 3. sheriff-o-matic uses spaces: {{ label }} (17 files out of 21) Personally I think spaces are more readable, and I carried that style over from sheriff-o-matic without realizing other elements in Chrome didn't use spaces. But it's more important that we stay consistent with 1) and 2) than with 3) and it doesn't bother me too much. [1] https://code.google.com/p/chromium/codesearch#search/&q=polymer%20file:.html%... [2] https://code.google.com/p/chromium/codesearch#search/&q=polymer%20file:.html%... [3] https://code.google.com/p/chromium/codesearch#search/&q=polymer%20file:.html%... michaelpg 2015/02/18 00:17:18 ping on this nit Show quoted text On 2015/02/13 00:08:28, michaelpg wrote: > nit: 12, 14, 15 should be limited to 80 chars wide ping on this nit Jeremy Klein 2015/02/18 01:10:49 Done. Show quoted text On 2015/02/18 00:17:18, michaelpg wrote: > On 2015/02/13 00:08:28, michaelpg wrote: > > nit: 12, 14, 15 should be limited to 80 chars wide > > ping on this nit Done.
	13 value="{{value}}" disabled?="{{disabled}}" error="{{error}}">

	14 <input is="core-input" id="input" value="{{value}}" committedValue="{{comm ittedValue}}"

	15 disabled?="{{disabled}}" required="{{required}}" pattern="{{pattern}}" type="{{type}}">

	16 </paper-input-decorator>

	17 </template>

	18 <script src="cr_input.js"></script>

	19 </polymer-element>

OLD	NEW