chrome/browser/resources/md_settings/md_settings.html - Issue 918913002: Add a <cr-input> element to cr_elements.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/md_settings/md_settings.html

Issue 918913002: Add a <cr-input> element to cr_elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <meta charset="utf-8">	4 <meta charset="utf-8">

5 <title>Settings</title>	5 <title>Settings</title>

6 <link rel="import"	6 <link rel="import"

7 href="chrome://resources/cr_elements/cr_toggle_button/cr_toggle_button.htm l">	7 href="chrome://resources/cr_elements/cr_toggle_button/cr_toggle_button.htm l">

	8 <link rel="import" href="chrome://resources/cr_elements/cr_input/cr_input.html ">
	michaelpg 2015/02/13 00:08:28 nit: let's ask dbeam whether the 80-char limit app nit: let's ask dbeam whether the 80-char limit applies here. http://www.chromium.org/developers/web-development-style-guide seems to imply that it doesn't. Jeremy Klein 2015/02/13 00:22:54 I thought it was 100 for html, but it could be dif Show quoted text On 2015/02/13 00:08:28, michaelpg wrote: > nit: let's ask dbeam whether the 80-char limit applies here. > > http://www.chromium.org/developers/web-development-style-guide seems to imply > that it doesn't. I thought it was 100 for html, but it could be different for Chrome style. michaelpg 2015/02/18 00:17:17 It's definitely 80 for html in Chromium. I'd still Show quoted text On 2015/02/13 00:22:54, Jeremy Klein wrote: > On 2015/02/13 00:08:28, michaelpg wrote: > > nit: let's ask dbeam whether the 80-char limit applies here. > > > > http://www.chromium.org/developers/web-development-style-guide seems to imply > > that it doesn't. > > I thought it was 100 for html, but it could be different for Chrome style. It's definitely 80 for html in Chromium. I'd still like dbeam@ to weigh in on how we should handle long lines in <head>.
8 <link rel="import"	9 <link rel="import"

9 href="chrome://resources/polymer/paper-button/paper-button.html">	10 href="chrome://resources/polymer/paper-button/paper-button.html">

10 </head>	11 </head>

11 <body>	12 <body>

12 <header>	13 <header>

13 <h1>Settings</h1>	14 <h1>Settings</h1>

14 </header>	15 </header>

15 <div class="main">	16 <div class="main">

16 <paper-button id="manage-button" raised>Manage</paper-button>	17 <paper-button id="manage-button" raised>Manage</paper-button>

17 <cr-toggle-button checked></cr-toggle-button>	18 <cr-toggle-button checked></cr-toggle-button>

	19 <section>

	20 <h3>cr-input</h3>

	21 <cr-input></cr-input>

	22 </section>

18 </div>	23 </div>

19 </body>	24 </body>

20 </html>	25 </html>

OLD	NEW

« no previous file with comments | « no previous file | ui/webui/resources/cr_elements/cr_input/cr_input.css » ('j') | ui/webui/resources/cr_elements/cr_input/cr_input.html » ('J')