Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Unified Diff: dart/pkg/compiler/lib/src/js_backend/backend.dart

Issue 918893003: Revert "Remove implicit dependencies." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/pkg/compiler/lib/src/js_backend/backend.dart
diff --git a/dart/pkg/compiler/lib/src/js_backend/backend.dart b/dart/pkg/compiler/lib/src/js_backend/backend.dart
index 3b64c8d45633a4cfbaa5f9196016834cd4d3d43a..da276e4ddf9f576ffa39ea7997f6ebcd03500571 100644
--- a/dart/pkg/compiler/lib/src/js_backend/backend.dart
+++ b/dart/pkg/compiler/lib/src/js_backend/backend.dart
@@ -954,12 +954,6 @@ class JavaScriptBackend extends Backend {
assert(traceHelper != null);
enqueueInResolution(traceHelper, registry);
}
-
- // TODO(ahe): Don't know who uses this class, but it wasn't correctly
- // enqueued after we stopped compiling the @proxy constant eagerly.
- world.registerInstantiatedClass(
- interceptorsLibrary.findLocal('JSUInt31'), registry);
-
registerCheckedModeHelpers(registry);
}
@@ -2403,12 +2397,6 @@ class JavaScriptBackend extends Backend {
}
void registerMainHasArguments(Enqueuer enqueuer) {
- // The first argument could be a list of strings.
- enqueuer.registerInstantiatedClass(
- listImplementation, compiler.globalDependencies);
- enqueuer.registerInstantiatedClass(
- stringImplementation, compiler.globalDependencies);
-
// If the main method takes arguments, this compilation could be the target
// of Isolate.spawnUri. Strictly speaking, that can happen also if main
// takes no arguments, but in this case the spawned isolate can't
@@ -2580,10 +2568,9 @@ class JavaScriptResolutionCallbacks extends ResolutionCallbacks {
void onStackTraceInCatch(Registry registry) {
assert(registry.isForResolution);
registerBackendStaticInvocation(backend.getTraceFromException(), registry);
- backend.compiler.enqueuer.resolution.registerInstantiatedClass(
- backend.compiler.stackTraceClass, registry);
}
+
void onTypeVariableExpression(Registry registry) {
assert(registry.isForResolution);
registerBackendStaticInvocation(backend.getSetRuntimeTypeInfo(), registry);
@@ -2711,45 +2698,6 @@ class JavaScriptResolutionCallbacks extends ResolutionCallbacks {
registerBackendStaticInvocation(
backend.compiler.symbolValidatedConstructor, registry);
}
-
- void onLiteralInt(Registry registry) {
- backend.compiler.enqueuer.resolution.registerInstantiatedClass(
- backend.intImplementation, registry);
- }
-
- void onLiteralDouble(Registry registry) {
- backend.compiler.enqueuer.resolution.registerInstantiatedClass(
- backend.doubleImplementation, registry);
- }
-
- void onLiteralBool(Registry registry) {
- backend.compiler.enqueuer.resolution.registerInstantiatedClass(
- backend.boolImplementation, registry);
- }
-
- void onLiteralString(Registry registry) {
- backend.compiler.enqueuer.resolution.registerInstantiatedClass(
- // TODO(ahe): For some reason using [backend.stringImplementation] here
- // confuses dart2js during override checks.
- backend.compiler.stringClass, registry);
- }
-
- void onLiteralNull(Registry registry) {
- backend.compiler.enqueuer.resolution.registerInstantiatedClass(
- backend.nullImplementation, registry);
- }
-
- void onLiteralSymbol(Registry registry) {
- backend.compiler.enqueuer.resolution.registerInstantiatedClass(
- backend.compiler.symbolClass, registry);
- backend.compiler.enqueuer.resolution.registerStaticUse(
- backend.compiler.symbolConstructor.declaration);
- }
-
- void onLiteralFunction(Registry registry) {
- backend.compiler.enqueuer.resolution.registerInstantiatedClass(
- backend.functionImplementation, registry);
- }
}
/// Records that [constant] is used by the element behind [registry].
« no previous file with comments | « dart/pkg/compiler/lib/src/dart_backend/backend.dart ('k') | dart/pkg/compiler/lib/src/resolution/members.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698