Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 918883003: (NoCommit) Check which platform accepts getUnderestimatedStackLimit() (Closed)

Created:
5 years, 10 months ago by peria
Modified:
5 years, 8 months ago
Reviewers:
haraken
CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Check which platform accepts getUnderestimatedStackLimit() BUG=457982

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Change threashold #

Patch Set 4 : #

Patch Set 5 : Add another test #

Patch Set 6 : #

Patch Set 7 : Update a test #

Patch Set 8 : #

Patch Set 9 : Add informational assert #

Patch Set 10 : #

Patch Set 11 : #

Patch Set 12 : #

Patch Set 13 : Revert other than ASSERT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -6 lines) Patch
M Source/platform/heap/StackFrameDepth.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +41 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
haraken
Shall we run more bots including Android and Chrome OS?
5 years, 10 months ago (2015-02-12 04:02:37 UTC) #2
peria
On 2015/02/12 04:02:37, haraken wrote: > Shall we run more bots including Android and Chrome ...
5 years, 10 months ago (2015-02-16 07:37:06 UTC) #3
haraken
On 2015/02/16 07:37:06, peria wrote: > On 2015/02/12 04:02:37, haraken wrote: > > Shall we ...
5 years, 10 months ago (2015-02-16 07:49:51 UTC) #4
peria
5 years, 10 months ago (2015-02-16 07:58:08 UTC) #5 
On 2015/02/16 07:49:51, haraken wrote:
> On 2015/02/16 07:37:06, peria wrote:
> > On 2015/02/12 04:02:37, haraken wrote:
> > > Shall we run more bots including Android and Chrome OS?
> > 
> > I expect PS13 is the last set for testing.
> > 
> > It looks that all Android environment work well with the new estimation,
> > and ChromeOS environments need the old estimation.
> > In summary, we have to enable the new estimation on ChromeOS and MacOSX in
> > future.
> 
> What do you mean? ChromeOS needs an old estimation but we need to enable the
new
> estimation??

We cannot enable the new method on ChromeOS with current implementation.
It seems that we need more hacks to get stack base address and stack size
correctly on these platforms.

> > In summary, we have to enable the new estimation on ChromeOS and MacOSX in
> > future.
"have to" was wrong.  I mean that I would like to enable it on these two OS.

Powered by Google App Engine
This is Rietveld 408576698