content/browser/compositor/software_browser_compositor_output_surface.cc - Issue 918883002: Change input latency result to depend on start of GPU swap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/compositor/software_browser_compositor_output_surface.cc

Issue 918883002: Change input latency result to depend on start of GPU swap (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: cleanup RWHLT Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/browser/renderer_host/render_widget_host_latency_tracker.cc » ('j') | content/browser/renderer_host/render_widget_host_latency_tracker.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/compositor/software_browser_compositor_output_surface.cc

diff --git a/content/browser/compositor/software_browser_compositor_output_surface.cc b/content/browser/compositor/software_browser_compositor_output_surface.cc

index 671d8134b989ab5cbee65ad23e7c596f942c46f9..d5643a145a85b1610eeb0fbe16f3e262e8d0e8a7 100644

--- a/content/browser/compositor/software_browser_compositor_output_surface.cc

+++ b/content/browser/compositor/software_browser_compositor_output_surface.cc

@@ -34,9 +34,13 @@ SoftwareBrowserCompositorOutputSurface::

void SoftwareBrowserCompositorOutputSurface::SwapBuffers(

cc::CompositorFrame* frame) {

- for (size_t i = 0; i < frame->metadata.latency_info.size(); i++) {

- frame->metadata.latency_info[i].AddLatencyNumber(

- ui::INPUT_EVENT_LATENCY_TERMINATED_FRAME_SWAP_COMPONENT, 0, 0);

+ base::TimeTicks swap_time = base::TimeTicks::Now();

+ for (auto& latency : frame->metadata.latency_info) {

+ latency.AddLatencyNumberWithTimestamp(

+ ui::INPUT_EVENT_GPU_SWAP_BUFFER_COMPONENT, 0, 0, swap_time, 1);

+ latency.AddLatencyNumberWithTimestamp(

+ ui::INPUT_EVENT_LATENCY_TERMINATED_FRAME_SWAP_COMPONENT, 0, 0,

+ swap_time, 1);

}

base::MessageLoop::current()->PostTask(

FROM_HERE,