build/android/developer_recommended_flags.gypi - Issue 918833002: Comment that gyp_managed_install requires a userdebug flashed device.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/developer_recommended_flags.gypi

Issue 918833002: Comment that gyp_managed_install requires a userdebug flashed device. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/developer_recommended_flags.gypi

diff --git a/build/android/developer_recommended_flags.gypi b/build/android/developer_recommended_flags.gypi

index 3a3db0a3138c205e2a918cff0f0a5b9d168036a6..8088eaef4db431c739494153924c0962b89a99e9 100644

--- a/build/android/developer_recommended_flags.gypi

+++ b/build/android/developer_recommended_flags.gypi

@@ -38,6 +38,7 @@

# This comes with some caveats:

# Only works with a single device connected (it will print a warning if

# zero or multiple devices are attached).

+ # Device must be flashed with a userdebug unsigned Android build.

klundberg 2015/02/12 17:21:14 nit: we normally use "user-debug".

scheib 2015/02/12 18:00:07 Done.

# Some actions are always run (i.e. ninja will never say "no work to do").

'gyp_managed_install%': 1,

« no previous file with comments | « no previous file | no next file » | no next file with comments »