Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 918833002: Comment that gyp_managed_install requires a userdebug flashed device. (Closed)

Created:
5 years, 10 months ago by scheib
Modified:
5 years, 10 months ago
Reviewers:
klundberg
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Comment that gyp_managed_install requires a userdebug flashed device. Committed: https://crrev.com/036bf74db1cc3d68b9c1af2364f0a83674d7aee3 Cr-Commit-Position: refs/heads/master@{#316014}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/android/developer_recommended_flags.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
scheib
5 years, 10 months ago (2015-02-11 23:47:27 UTC) #2
klundberg
I don't know much about this but the comment LGTM with a minor nit. https://codereview.chromium.org/918833002/diff/1/build/android/developer_recommended_flags.gypi ...
5 years, 10 months ago (2015-02-12 17:21:14 UTC) #3
scheib
https://codereview.chromium.org/918833002/diff/1/build/android/developer_recommended_flags.gypi File build/android/developer_recommended_flags.gypi (right): https://codereview.chromium.org/918833002/diff/1/build/android/developer_recommended_flags.gypi#newcode41 build/android/developer_recommended_flags.gypi:41: # Device must be flashed with a userdebug unsigned ...
5 years, 10 months ago (2015-02-12 18:00:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/918833002/20001
5 years, 10 months ago (2015-02-12 18:01:13 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-12 19:13:28 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-12 19:14:00 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/036bf74db1cc3d68b9c1af2364f0a83674d7aee3
Cr-Commit-Position: refs/heads/master@{#316014}

Powered by Google App Engine
This is Rietveld 408576698