Introduce PPB_Flash_MessageLoop interface for Pepper Flash.

webkit/plugins/ppapi/ppb_flash_message_loop_impl.h

Index: webkit/plugins/ppapi/ppb_flash_message_loop_impl.h
diff --git a/webkit/plugins/ppapi/ppb_flash_message_loop_impl.h b/webkit/plugins/ppapi/ppb_flash_message_loop_impl.h
new file mode 100644
index 0000000000000000000000000000000000000000..a84ee08d8c3599546c72aeca43a2f2fe3d5052ea
--- /dev/null
+++ b/webkit/plugins/ppapi/ppb_flash_message_loop_impl.h
@@ -0,0 +1,50 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef WEBKIT_PLUGINS_PPAPI_PPB_FLASH_MESSAGE_LOOP_IMPL_H_
+#define WEBKIT_PLUGINS_PPAPI_PPB_FLASH_MESSAGE_LOOP_IMPL_H_
+
+#include "base/basictypes.h"
+#include "base/compiler_specific.h"
+#include "base/memory/ref_counted.h"
+#include "ppapi/shared_impl/resource.h"
+#include "ppapi/thunk/ppb_flash_message_loop_api.h"
+
+namespace webkit {
+namespace ppapi {
+
+class PPB_Flash_MessageLoop_Impl
+    : public ::ppapi::Resource,
+      public ::ppapi::thunk::PPB_Flash_MessageLoop_API {
+ public:
+  virtual ~PPB_Flash_MessageLoop_Impl();
+
+  static PP_Resource Create(PP_Instance instance);
+
+  // Resource.
+  virtual ::ppapi::thunk::PPB_Flash_MessageLoop_API*
+      AsPPB_Flash_MessageLoop_API() OVERRIDE;
+
+  // PPB_Flash_MessageLoop_API implementation.
+  virtual int32_t Run() OVERRIDE;
+  virtual void Quit() OVERRIDE;
+  virtual void RunFromHostProxy(PP_CompletionCallback callback) OVERRIDE;

[viettrungluu, 2012/01/17 21:26:06]

Would I be wrong in saying that this callback isn't really a PPAPI completion
callback per se?

[yzshen1, 2012/01/18 07:43:35]

:)
It is not strictly a PPAPI completion callback, because
- it is called before this method returns.

However,
- it is used to notify the completion of an operation.
- it is exactly called once.
- and it returns pp_errors vales.

I personally think it is okay to use PP_CompletionCallback here with some clear
comments (in ppb_flash_message_loop_api.h). Does that make sense?

+
+ private:
+  class State;
+
+  explicit PPB_Flash_MessageLoop_Impl(PP_Instance instance);
+
+  int32_t InternalRun(PP_CompletionCallback callback);
+  void InternalQuit(int32_t result);
+
+  scoped_refptr<State> state_;
+
+  DISALLOW_COPY_AND_ASSIGN(PPB_Flash_MessageLoop_Impl);
+};
+
+}  // namespace ppapi
+}  // namespace webkit
+
+#endif  // WEBKIT_PLUGINS_PPAPI_PPB_FLASH_MESSAGE_LOOP_IMPL_H_