CRD Viewport Management refactor

remoting/webapp/crd/js/host.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * The deserialized form of the chromoting host as returned by Apiary.
  */
 
+var remoting = remoting || {};
+
+(function() {
+
 'use strict';
 
-/** @suppress {duplicate} */
-var remoting = remoting || {};
-
 /**
  * Note that the object has more fields than are detailed below--these
  * are just the ones that we refer to directly.
+ *
+ * TODO(kelvinp):Make fields private and expose them via getters.

[Jamie, 2015/02/18 00:33:10]

This is basically a struct; I don't think there's much value in using getters.

  * @constructor
  */
 remoting.Host = function() {
   /** @type {string} */
   this.hostName = '';
   /** @type {string} */
   this.hostId = '';
   /** @type {string} */
   this.status = '';
   /** @type {string} */
   this.jabberId = '';
   /** @type {string} */
   this.publicKey = '';
   /** @type {string} */
   this.hostVersion = '';
   /** @type {Array<string>} */
   this.tokenUrlPatterns = [];
   /** @type {string} */
   this.updatedTime = '';
   /** @type {string} */
   this.hostOfflineReason = '';
+  /** @type {remoting.Host.Options} */

[Jamie, 2015/02/18 00:33:10]

Either make this private, or remove the getter. Since nothing else in the class
has getters, I'd lean towards the latter.

+  this.options_ = new remoting.Host.Options(this.hostId);
+};
+
+/** @return {remoting.Host.Options} */
+remoting.Host.prototype.options = function() {
+  return this.options_;
 };
 
 /**
+ * @constructor
+ * @param {string} hostId
+ * @struct
+ */
+remoting.Host.Options = function(hostId) {
+  /** @private */
+  this.hostId_ = hostId;
+  /** @private */
+  this.isInitialized_ = false;
+  /** @type {boolean} */
+  this.shrinkToFit = false;
+  /** @type {boolean} */
+  this.resizeToClient = false;
+  /** @type {string} */
+  this.remapKeys = '';
+  /** @type {number} */
+  this.desktopScale = 1;
+};
+
+remoting.Host.Options.prototype.save = function() {
+  base.debug.assert(this.isInitialized_);
+  remoting.HostSettings.save(this.hostId_, this);
+};
+
+
+/** @return {Promise} A promise that resolves when the settings are loaded. */
+remoting.Host.Options.prototype.load = function() {
+  var that = this;
+  if (this.isInitialized_) {
+    return Promise.resolve();
+  }
+  return base.Promise.as(remoting.HostSettings.load, [this.hostId_]).then(
+    /**
+     * @param {Object.<string|boolean|number>} options
+     */
+    function(options) {
+      that.isInitialized_ = true;
+      that.resizeToClient =
+          getBooleanAttr(options, 'resizeToClient', false);
+      that.shrinkToFit = getBooleanAttr(options, 'shrinkToFit', false);
+      that.desktopScale = getNumberAttr(options, 'desktopScale', 1);
+      that.remapKeys = getStringAttr(options, 'remapKeys', '');
+    });
+};
+
+/**
  * Determine whether a host needs to be manually updated. This is the case if
  * the host's major version number is more than 1 lower than that of the web-
  * app (a difference of 1 is tolerated due to the different update mechanisms)
  * and if the host is on-line (off-line hosts are not expected to auto-update).
  *
  * @param {remoting.Host} host The host information from the directory.
  * @param {string|number} webappVersion The version number of the web-app, in
  *     either dotted-decimal notation notation, or directly represented by the
  *     major version.
  * @return {boolean} True if the host is on-line but out-of-date.
  */
 remoting.Host.needsUpdate = function(host, webappVersion) {
   if (host.status != 'ONLINE') {
     return false;
   }
   var hostMajorVersion = parseInt(host.hostVersion, 10);
   if (isNaN(hostMajorVersion)) {
     // Host versions 26 and higher include the version number in heartbeats,
     // so if it's missing then the host is at most version 25.
     hostMajorVersion = 25;
   }
   return (parseInt(webappVersion, 10) - hostMajorVersion) > 1;
 };
+
+})();