Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 9187031: Add perf expectations for TEXTREL counts on 32-bit Linux binaries (Closed)

Created:
8 years, 11 months ago by Roland McGrath
Modified:
8 years, 11 months ago
Reviewers:
cmp
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Add perf expectations for TEXTREL counts on 32-bit Linux binaries We want sheriffs to notice if any TEXTRELs are added. A count above zero is unacceptable on anything but libffmpegsumo.so (which one day should get down to zero as well, but it's known to be nontrivial). BUG=109318 TEST= none R=cmp@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117449

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M tools/perf_expectations/perf_expectations.json View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Roland McGrath
8 years, 11 months ago (2012-01-11 22:40:12 UTC) #1
cmp
8 years, 11 months ago (2012-01-11 22:45:47 UTC) #2
lgtm with a nit and a note

nit: I checked first and I don't see an email from you to chromium-dev as a PSA
noting that there's a new way for patches to get reverted: by increasing TEXTREL
counts.  Please send that, then land this a couple hours later.

note: This is most likely the first sizes expectation that's added that's
absolute and 0.  I expect things to work, but be on the lookout for any
weirdness.

Powered by Google App Engine
This is Rietveld 408576698