Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(740)

Issue 918703002: Re-add markForPaginationRelayoutIfNeeded() for all table children. (Closed)

Created:
5 years, 10 months ago by mstensho (USE GERRIT)
Modified:
5 years, 10 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Re-add markForPaginationRelayoutIfNeeded() for all table children. This piece of code got removed in https://codereview.chromium.org/196533012 , assumedly because some merge conflict wasn't resolved correctly. Now we can re-enable fast/multicol/table-cell-content-change.html for region-based multicol. BUG=348064 R=leviw@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189998

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M LayoutTests/TestExpectations View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutTable.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
mstensho (USE GERRIT)
5 years, 10 months ago (2015-02-11 18:58:44 UTC) #1
leviw_travelin_and_unemployed
D'oh! Thanks for catching this. LGTM.
5 years, 10 months ago (2015-02-11 19:00:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/918703002/1
5 years, 10 months ago (2015-02-11 19:02:35 UTC) #4
commit-bot: I haz the power
5 years, 10 months ago (2015-02-11 22:17:35 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189998

Powered by Google App Engine
This is Rietveld 408576698