Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 918613003: [ServiceWorker] Fix thread jumping race condition in SWProviderHost. (Closed)

Created:
5 years, 10 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 10 months ago
Reviewers:
michaeln
CC:
chromium-reviews, darin-cc_chromium.org, horo+watch_chromium.org, jam, jsbell+serviceworker_chromium.org, kinuko+serviceworker, kinuko+watch, michaeln, nhiroki, serviceworker-reviews, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ServiceWorker] Fix thread jumping race condition in SWProviderHost. This is using PostTaskAndReplyWithResult() instead of PostTask, making sure that the callback is destroyed in the same thread as it was called in. BUG=457287 Committed: https://crrev.com/8f5ceb741ae7f126c5acc67c7b28949efebeef24 Cr-Commit-Position: refs/heads/master@{#316198}

Patch Set 1 #

Patch Set 2 : coding style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -29 lines) Patch
M content/browser/service_worker/service_worker_provider_host.cc View 1 3 chunks +19 lines, -29 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mlamouri (slow - plz ping)
5 years, 10 months ago (2015-02-12 22:50:55 UTC) #2
michaeln
lgtm, nice that PostTaskAndReplay uses Unretained ptrs in there
5 years, 10 months ago (2015-02-13 00:53:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/918613003/20001
5 years, 10 months ago (2015-02-13 08:56:58 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-13 09:45:54 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 09:46:48 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8f5ceb741ae7f126c5acc67c7b28949efebeef24
Cr-Commit-Position: refs/heads/master@{#316198}

Powered by Google App Engine
This is Rietveld 408576698