Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 918603004: new classes: implement correct check for uninitialized this in 'super()' (Closed)

Created:
5 years, 10 months ago by Dmitry Lomov (no reviews)
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

new classes: implement correct check for uninitialized this in 'super()' R=arv@chromium.org BUG=v8:3834 LOG=N Committed: https://crrev.com/fdcf3e59ba4af1aa3c5b31a18e615169c97958ab Cr-Commit-Position: refs/heads/master@{#26599}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Patch for landing #

Patch Set 3 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -48 lines) Patch
M src/arm/full-codegen-arm.cc View 1 2 2 chunks +11 lines, -12 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 2 2 chunks +10 lines, -11 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 2 2 chunks +10 lines, -10 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 2 3 chunks +9 lines, -13 lines 0 comments Download
M test/mjsunit/harmony/classes-experimental.js View 2 chunks +56 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Dmitry Lomov (no reviews)
PTAL
5 years, 10 months ago (2015-02-11 18:08:16 UTC) #1
arv (Not doing code reviews)
LGTM https://codereview.chromium.org/918603004/diff/1/src/ia32/full-codegen-ia32.cc File src/ia32/full-codegen-ia32.cc (right): https://codereview.chromium.org/918603004/diff/1/src/ia32/full-codegen-ia32.cc#newcode3197 src/ia32/full-codegen-ia32.cc:3197: remove one empty line
5 years, 10 months ago (2015-02-11 19:36:24 UTC) #2
Dmitry Lomov (no reviews)
https://codereview.chromium.org/918603004/diff/1/src/ia32/full-codegen-ia32.cc File src/ia32/full-codegen-ia32.cc (right): https://codereview.chromium.org/918603004/diff/1/src/ia32/full-codegen-ia32.cc#newcode3197 src/ia32/full-codegen-ia32.cc:3197: On 2015/02/11 19:36:24, arv wrote: > remove one empty ...
5 years, 10 months ago (2015-02-11 19:55:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/918603004/20001
5 years, 10 months ago (2015-02-11 19:56:55 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/1403)
5 years, 10 months ago (2015-02-11 19:59:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/918603004/40001
5 years, 10 months ago (2015-02-11 20:25:55 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-11 20:47:28 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-11 20:47:44 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fdcf3e59ba4af1aa3c5b31a18e615169c97958ab
Cr-Commit-Position: refs/heads/master@{#26599}

Powered by Google App Engine
This is Rietveld 408576698