Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.h - Issue 9186030: Merge 104736 - [v8] Int16Array.set(array, offset) fails on first execution

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.h

Issue 9186030: Merge 104736 - [v8] Int16Array.set(array, offset) fails on first execution (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/963/

Patch Set: Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/canvas/webgl/array-set-with-offset-expected.txt ('k') | Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.h

===================================================================

--- Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.h (revision 104771)

+++ Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.h (working copy)

@@ -51,7 +51,7 @@

// Copy the elements from the source array to the typed destination array by

// invoking the 'set' method of the destination array in JS.

-void copyElements(v8::Handle<v8::Object> destArray, v8::Handle<v8::Object> srcArray);

+void copyElements(v8::Handle<v8::Object> destArray, v8::Handle<v8::Object> srcArray, uint32_t offset);

// Template function used by the ArrayBufferView*Constructor callbacks.

@@ -171,7 +171,7 @@

args.Holder()->SetIndexedPropertiesToExternalArrayData(array.get()->baseAddress(), arrayType, array.get()->length());

if (!srcArray.IsEmpty())

- copyElements(args.Holder(), srcArray);

+ copyElements(args.Holder(), srcArray, 0);

return toV8(array.release(), args.Holder(), MarkIndependent);

}

@@ -212,7 +212,7 @@

else {

if (!fastSetInstalled(args.Holder())) {

installFastSet(args.Holder());

- copyElements(args.Holder(), array);

+ copyElements(args.Holder(), array, offset);

} else {

for (uint32_t i = 0; i < length; i++)

impl->set(offset + i, array->Get(i)->NumberValue());