Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: gcc/config/i386/nacl.h

Issue 9186013: Make -Os a fatal error (Closed) Base URL: http://git.chromium.org/native_client/nacl-gcc.git@master
Patch Set: appengine hiccup Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gcc/config/i386/nacl.h
diff --git a/gcc/config/i386/nacl.h b/gcc/config/i386/nacl.h
index f11da3f940a3fb7b9f34c677cc907436daf77ebc..e903e029865e098946269d95aac8de6d69c88224 100644
--- a/gcc/config/i386/nacl.h
+++ b/gcc/config/i386/nacl.h
@@ -268,3 +268,12 @@ Boston, MA 02111-1307, USA. */
#define DWARF2_ADDR_SIZE \
(TARGET_NACL ? (TARGET_64BIT ? 8 : 4) : \
(POINTER_SIZE / BITS_PER_UNIT))
+
+/* -Os is broken and we aren't putting the work into fixing it.
+ See http://code.google.com/p/nativeclient/issues/detail?id=2284 */
+#undef SUBTARGET_OVERRIDE_OPTIONS
+#define SUBTARGET_OVERRIDE_OPTIONS \
+ do { \
+ if (TARGET_NACL && optimize_size) \
+ error ("-Os is not supported by the Native Client compiler"); \
+ } while (0)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698