Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 918553002: Initialize all MouseEvent members in all constructors (Closed)

Created:
5 years, 10 months ago by philipj_slow
Modified:
5 years, 10 months ago
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Initialize all MouseEvent members in all constructors In the "Improve detection of touch events when hiding media controls" change <https://codereview.chromium.org/453493002>;, m_syntheticEventType was initialized only in one constructor. BUG=401177, 445305 R=igsolla@chromium.org, rbyers@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189968

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M Source/core/events/MouseEvent.cpp View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
philipj_slow
Ignacio, Rick, PTAL. I will CC you on the second bug for context.
5 years, 10 months ago (2015-02-11 10:22:46 UTC) #1
Rick Byers
LGTM. Sorry I missed that in review - thanks for fixing!
5 years, 10 months ago (2015-02-11 10:52:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/918553002/1
5 years, 10 months ago (2015-02-11 12:15:16 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=189968
5 years, 10 months ago (2015-02-11 12:18:44 UTC) #5
Ignacio Solla
5 years, 10 months ago (2015-02-11 13:32:22 UTC) #6
Message was sent while issue was closed. 
Sorry I missed that. Thanks for fixing!

Powered by Google App Engine
This is Rietveld 408576698